divmod-dev team mailing list archive

[Jean-Paul Calderone <exarkun@xxxxxxxxxxxxxxxxx>]

Jean-Paul Calderone has proposed merging lp:~exarkun/divmod.org/nevow-do-not-segfault into lp:divmod.org with lp:~exarkun/divmod.org/nevow-setup.py-declare-twisted-dependency as a prerequisite.

Commit message:
Get rid of the very unsafe `nevow.test.segfault` module and instead have the test which previously used it generate the code it needs when it runs.

Requested reviews:
  Divmod-dev (divmod-dev)

For more details, see:
https://code.launchpad.net/~exarkun/divmod.org/nevow-do-not-segfault/+merge/222432
-- 
https://code.launchpad.net/~exarkun/divmod.org/nevow-do-not-segfault/+merge/222432
Your team Divmod-dev is requested to review the proposed merge of lp:~exarkun/divmod.org/nevow-do-not-segfault into lp:divmod.org.

=== removed file 'Nevow/nevow/test/segfault.py'
--- Nevow/nevow/test/segfault.py	2009-07-04 00:32:14 +0000
+++ Nevow/nevow/test/segfault.py	1970-01-01 00:00:00 +0000
@@ -1,11 +0,0 @@
-#!/usr/bin/python
-
-"""
-Generate an unhandled SIGSEGV for this process immediately upon import.
-
-@see: L{nevow.test.test_testutil.JavaScriptTests.test_signalledExit}.
-"""
-
-import os, signal
-
-os.kill(os.getpid(), signal.SIGSEGV)

=== modified file 'Nevow/nevow/test/test_testutil.py'
--- Nevow/nevow/test/test_testutil.py	2010-02-06 04:33:05 +0000
+++ Nevow/nevow/test/test_testutil.py	2014-06-07 13:01:05 +0000
@@ -188,7 +188,14 @@
         An error should be reported if the JavaScript interpreter exits because
         it received a signal.
         """
-        segfault = FilePath(__file__).sibling('segfault.py')
+        segfault = FilePath(self.mktemp())
+        segfault.setContent("""\
+#!/usr/bin/python
+# Generate an unhandled SIGSEGV for this process immediately upon import.
+
+import os, signal
+os.kill(os.getpid(), signal.SIGSEGV)
+""")
 
         def stubFinder():
             return sys.executable