do-plugins team mailing list archive

[Alex Launi <alex.launi@xxxxxxxxx>]

Vote: Needs Fixing none
Style fixes: Methods and their params should have spaces, ex) method (param1, param2). The same is true for declarations. There are a bunch of double newlines, you should only have one newline between things.

In Service.cs, the constructor should be at the top of the class, and I'm not sure about the name and description. Can you make the name something like 'name + " service"', so it would show up as "ssh service", and then make the description more descriptive, maybe "system " + name + " service", or something.

Both works in your ItemSource name should be capitalized, "System Services"

In Services, why not have GetServices return a List<IItem>, so you don't have to loop through it again just to make the strings into services? Save yourself some work.

why is the defaultBlacklist string public, also class constants like that should not be camelCased, use underscores for class_variables.

for your blacklisting, I would find a clever regexp to use there, the matching on *s is rather inelegant.

your config ui could also use some work, it's not very user friendly to have a text box asking for the graphical administration command, there should be a way to pull that out of a gconf setting or something, and for the text box you should use a nodeview similar to the one in the File UI.
-- 
https://code.launchpad.net/~karol-bedkowski/do-plugins/systemservices/+merge/2317
You are subscribed to branch lp:do-plugins/community-future.