do-plugins team mailing list archive

[Alex Launi <alex.launi@xxxxxxxxx>]

Vote: Needs Fixing none
Zim.cs:
Why do you have a private constructor that does nothing? Remove it.

Too many levels deep, refactor that to not go so deep, rather than enclosing a block in an if, do something like
if (!condition) return;
// then put the code here

again, drop System.IO, and rather than calling more than one, do new [] {"a", "b", "c"}.Aggregate(Path.Combine);

ZimConfig:
I would drop this entirely, make which notebook an optional modifier. it needlessly limiting to make people chose which notebook they want to put their new page into.

Rework the other classes to reflect the comments made above, and then I'll do another review.
-- 
https://code.launchpad.net/~karol-bedkowski/do-plugins/zim/+merge/2300
You are subscribed to branch lp:do-plugins/community-future.