do-plugins team mailing list archive

[Alex Launi <alex.launi@xxxxxxxxx>]

ServiceItemSource, You don't need to (and shouldn't) give the fully qualified name for the ICollections. Just ICollection<IItem> (), also you should only have a single space for List<IItem> items;

You should not assign your strings to null, use the empty string "".

How did you make your default list? Seems like a weird hodgepodge of services. I would pick ones that everyone will have by default, or just have it empty.


Looks more or less ok otherwise though
-- 
https://code.launchpad.net/~karol-bedkowski/do-plugins/systemservices/+merge/2317
Your team GNOME Do Plugins Team is subscribed to branch lp:do-plugins/community-future.