do-plugins team mailing list archive

[Alex Launi <alex.launi@xxxxxxxxx>]

Patch comments: 
Why did you modify Makefile.include? Was that done by monodevelop perhaps?
You should also add yourself to the list of authors in the addin manifest (the addin.xml file).
In your configuration UI, maybe use a ComboEntry instead of a combobox, and an entry. This will be a lot cleaner of a UI. 
You changed a couple uses of "" to string.Empty, change them back. We use "", not string.Empty.
There seems to be a typo in Preferences.cs, you have: const string MicroblogServiceAddressKey = "{0}/ServiceAddres"; <-- note the missing 's'
You added a debugging writeline to Urls.cs, remove it. Remove any other WriteLines I missed, if it's debugging you want to leave, use the Log<T>.Debug () method (or similar).

There may be more issues, fix these then I will re-review. I haven't
actually tested/applied the patch, this was just a review of the patch
itself.

** Changed in: do-plugins
   Importance: Undecided => Wishlist
       Status: New => In Progress

-- 
Microbloggin Plugin - Support to Laconi.ca based.
https://bugs.launchpad.net/bugs/347724
You received this bug notification because you are a member of GNOME Do
Plugins Team, which is subscribed to GNOME Do Plugins.