← Back to team overview

documentation-packages team mailing list archive

[Bug 1599264] Re: [SRU] "When power is critically low" setting does nothing

 

Update description to be SRU compliant.

** Description changed:

- Since the move to systemd (I think) the setting in unity-control-center
- under "Power" that says:
+ [Impact]
  
- When power is critically low: [Hibernate | Power Off]
+ In unity-control-center (u-c-c) there is an option for taking an action
+ when "Power is critically low".  The choices are "Hibernate" or "Power
+ off".  Often Hibernate is a disabled option because of problems with
+ hibernate on various systems.
  
- doesn't actually do anything any more.
+ However - what to do in the event of a critically low power situation is
+ now handled by Upowerd automatically and so making a choice in u-c-c
+ does nothing at all.
  
- That action is now controlled by Upower config in
- /etc/UPower/UPower.conf.  At the end of that file you can see:
+ As such, leaving that option accessible to users will lead to confusion.
  
- # The action to take when "TimeAction" or "PercentageAction" above has been
- # reached for the batteries (UPS or laptop batteries) supplying the computer
- # 
- # Possible values are:
- # PowerOff
- # Hibernate
- # HybridSleep
- #
- # If HybridSleep isn't available, Hibernate will be used
- # If Hibernate isn't available, PowerOff will be used
- CriticalPowerAction=HybridSleep
+ This patch removes the option from the UI.
  
+ [Test Case]
  
- So the default action is HybridSleep and is not configurable by the user in the control center anymore.
+ On an unpatched machine with a battery (i.e. laptop) open the power
+ panel in u-c-c (Power/Settings menu in the top right corner -> System
+ Settings -> Power.  Note that the 2nd option down is "When power is
+ critically low".
  
- FWIW - I think the best thing to do is just remove that setting from
- u-c-c altogether.
+ Once this update is applied and u-c-c is closed and reopened, this
+ option is no longer present.
+ 
+ [Regression Potential]
+ There are some deletions from the ui file and some corresponding code deletions from the associated c file (cc-power-panel.c).
+ 
+ It is possible that extra code has been removed that could cause a crash
+ or affect other options in the power panel.
+ 
+ However, the changes are fairly small and easy to review.  Nothing looks
+ out of place.  Also testing has not shown any problems.

** Description changed:

  [Impact]
  
  In unity-control-center (u-c-c) there is an option for taking an action
  when "Power is critically low".  The choices are "Hibernate" or "Power
  off".  Often Hibernate is a disabled option because of problems with
  hibernate on various systems.
  
  However - what to do in the event of a critically low power situation is
  now handled by Upowerd automatically and so making a choice in u-c-c
  does nothing at all.
  
  As such, leaving that option accessible to users will lead to confusion.
  
  This patch removes the option from the UI.
  
  [Test Case]
  
  On an unpatched machine with a battery (i.e. laptop) open the power
  panel in u-c-c (Power/Settings menu in the top right corner -> System
  Settings -> Power.  Note that the 2nd option down is "When power is
  critically low".
  
  Once this update is applied and u-c-c is closed and reopened, this
  option is no longer present.
  
  [Regression Potential]
  There are some deletions from the ui file and some corresponding code deletions from the associated c file (cc-power-panel.c).
  
  It is possible that extra code has been removed that could cause a crash
  or affect other options in the power panel.
  
  However, the changes are fairly small and easy to review.  Nothing looks
  out of place.  Also testing has not shown any problems.
+ 
+ [Other Info]
+ 
+ Verbal (IRC) +1 from design via mpt.
+ +1 from docs team via mailing list.

-- 
You received this bug notification because you are a member of
Documentation Packages, which is subscribed to ubuntu-docs in Ubuntu.
https://bugs.launchpad.net/bugs/1599264

Title:
  [SRU] "When power is critically low" setting does nothing

Status in One Hundred Papercuts:
  Triaged
Status in ubuntu-docs package in Ubuntu:
  Triaged
Status in unity-control-center package in Ubuntu:
  Triaged
Status in ubuntu-docs source package in Xenial:
  Triaged
Status in unity-control-center source package in Xenial:
  Triaged
Status in ubuntu-docs source package in Yakkety:
  Triaged
Status in unity-control-center source package in Yakkety:
  Triaged

Bug description:
  [Impact]

  In unity-control-center (u-c-c) there is an option for taking an
  action when "Power is critically low".  The choices are "Hibernate" or
  "Power off".  Often Hibernate is a disabled option because of problems
  with hibernate on various systems.

  However - what to do in the event of a critically low power situation
  is now handled by Upowerd automatically and so making a choice in
  u-c-c does nothing at all.

  As such, leaving that option accessible to users will lead to
  confusion.

  This patch removes the option from the UI.

  [Test Case]

  On an unpatched machine with a battery (i.e. laptop) open the power
  panel in u-c-c (Power/Settings menu in the top right corner -> System
  Settings -> Power.  Note that the 2nd option down is "When power is
  critically low".

  Once this update is applied and u-c-c is closed and reopened, this
  option is no longer present.

  [Regression Potential]
  There are some deletions from the ui file and some corresponding code deletions from the associated c file (cc-power-panel.c).

  It is possible that extra code has been removed that could cause a
  crash or affect other options in the power panel.

  However, the changes are fairly small and easy to review.  Nothing
  looks out of place.  Also testing has not shown any problems.

  [Other Info]

  Verbal (IRC) +1 from design via mpt.
  +1 from docs team via mailing list.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hundredpapercuts/+bug/1599264/+subscriptions