dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Tue, Oct 11, 2005 at 04:20:29PM +0200, Johan Hoffman wrote:
> 
> >
> > Quoting Anders Logg <logg@xxxxxxxxx>:
> >
> >> On Tue, Oct 11, 2005 at 02:10:39PM +0200, Johan Jansson wrote:
> >> > On Tue, Oct 11, 2005 at 01:58:27PM +0200, Garth N. Wells wrote:
> >> > > Cywin is already detected in configure.ac in order to add
> >> cygwin-specific
> >> flags
> >> > > to CXXFlAGS. Is it possible to disbale a flag without redefining
> >> CXXFLAGS?
> >> > >
> >> > > Garth
> >> > >
> >> >
> >> > Ah, I see. Maybe something like this then?:
> >> >
> >> > # Add '-fPIC' for architectures which can handle it
> >> > if test `uname -o` != Cygwin; then
> >> >     echo "adding -fPIC to compiler flags"
> >> >     CXXFLAGS=$CXXFLAGS' -fPIC '
> >> > fi
> >> >
> >> > (and remove -fPIC from CXXFLAGS)
> >> >
> >> >   Johan
> >>
> >> If -fPIC is needed only on 64-bit systems, maybe there should be a
> >> test that checks instead for a 64-bit system?
> >
> >>From a maintainance point of view, I think that this is better. Define
> >> common
> > flags, then add platform specific flags after.
> >
> > Garth
> 
> I agree.

Then the question is how to test for AMD 64. Is it enough to do

# Add '-fPIC' for AMD 64 bit system
if test `uname -m` = x86_64; then
    echo "adding -fPIC to compiler flags"
    CXXFLAGS=$CXXFLAGS' -fPIC'
fi

?

/Anders