dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Thu, Jul 06, 2006 at 10:42:21PM +0200, Garth N. Wells wrote:
> On Thu, 2006-07-06 at 22:29 +0200, Anders Logg wrote:
> > On Thu, Jul 06, 2006 at 10:21:19PM +0200, Garth N. Wells wrote:
> > > On Thu, 2006-07-06 at 22:09 +0200, Anders Logg wrote:
> > > > The problem is that it doesn't play well together with other output
> > > > generated by DOLFIN.
> > > > 
> > > > If you do something like
> > > > 
> > > > DenseMatrix A;
> > > > dolfin::cout << "A = ";
> > > > A.disp();
> > > > 
> > > > Then the "A = " part might show up after the values are printed.
> > > > 
> > > > Using std::cout also bypasses dolfin_log(false) or any indentation
> > > > made by dolfin_begin() -- dolfin_end().
> > > > 
> > > 
> > > OK. I can add some code with our own format for printing matrices. We
> > > can do it better anyway as uBlas prints zero terms for sparse matrices
> > > which limits considerably the size of matrix that can practically be
> > > displayed.
> > > 
> > > Garth
> > 
> > Great. The code in PETScSparseMatrix should be easy to adapt (the
> > sparse part).
> > 
> > By the way, should we remove ncols in uBlasMatrix::getRow() since it's
> > provided by columns.size() anyway?
> > 
> 
> If you use the uBlas matrices only, I'd remove the whole function
> getRow. I think that a number of the ODE functions would be simpler if
> you use uBlas (no need to worry about the sparsity pattern). If you want
> to work with row i of matrix A, just do
>   row(A,i) = . . .
> or
>  . . . = row(A,i)
> 
> Garth 

I'm working on the port to uBlas right now. Indeed, some things can be
done much simpler with uBlas than before.

There are two options: either we remove it or we add a common
interface to GenericMatrix for getting a row that works with all
matrix types.

/Anders


> 
> 
> > /Anders
> > 
> > 
> > > > By the way, the TODO list is very incomplete and out of date. Is there
> > > > a better way to keep the list current? Could we use Bugzilla for TODO
> > > > items as well?
> > > > 
> > > ?
> > > > /Anders
> > > > 
> > > > 
> > > > On Thu, Jul 06, 2006 at 10:02:42PM +0200, Garth N. Wells wrote:
> > > > > Just a question about the TODO list. What's the problem with using
> > > > > std::cout in uBlasMatrix::disp()? uBlas overloads the operator << to
> > > > > deal with all the different uBlad data types.
> > > > > 
> > > > > Garth
> > > > > 
> > > > > 
> > > > > On Thu, 2006-07-06 at 21:56 +0200, DOLFIN wrote:
> > > > > > One or more new changesets pushed to the primary DOLFIN repository.
> > > > > > A short summary of the last three changesets is included below.
> > > > > > 
> > > > > > changeset:   2039:dbdd1de36f243ac6063a7b39a6fac82a4f8dd445
> > > > > > tag:         tip
> > > > > > user:        "Anders Logg <logg@xxxxxxxxx>"
> > > > > > date:        Thu Jul 06 21:55:22 2006 +0200
> > > > > > files:       TODO src/kernel/ode/dGqMethod.cpp src/kernel/quadrature/GaussianQuadrature.cpp
> > > > > > description:
> > > > > > Update TODO list.
> > > > > > 
> > > > > > 
> > > > > > changeset:   2038:afb2d919f7594f51eb5f9569e1497c956c9a6ecf
> > > > > > user:        "Garth N. Wells <g.n.wells@xxxxxxxxxx>"
> > > > > > date:        Thu Jul 06 19:48:55 2006 +0200
> > > > > > files:       src/kernel/la/dolfin/uBlasMatrix.h
> > > > > > description:
> > > > > > Fix constructor in uBlasMatrix.
> > > > > > 
> > > > > > 
> > > > > > changeset:   2037:c7974f4aff20c967f84e6fd6e7d6812e3a746f96
> > > > > > user:        "Garth N. Wells <g.n.wells@xxxxxxxxxx>"
> > > > > > date:        Thu Jul 06 17:12:19 2006 +0200
> > > > > > files:       src/kernel/la/Makefile.am src/kernel/la/Makefile.in src/kernel/la/dolfin/DenseMatrix.h src/kernel/la/dolfin/uBlasDenseMatrix.h src/kernel/la/dolfin/uBlasMatrix.h src/kernel/la/dolfin/uBlasSparseMatrix.h src/kernel/la/uBlasDenseMatrix.cpp src/kernel/la/uBlasSparseMatrix.cpp src/test/main.cpp
> > > > > > description:
> > > > > > Add constructors to uBlasDenseMatrix and uBlasSparseMatrix.
> > > > > > 
> > > > > > I've removed the compilation flag -DNDEBUG when using --enable-debug, so uBlas operations will be extremely slow when using --enable-debug.
> > > > > > 
> > > > > > 
> > > > > > -------------------------------------------------------
> > > > > > For more details, visit http://www.fenics.org/hg/dolfin
> > > > > > _______________________________________________
> > > > > > DOLFIN-dev mailing list
> > > > > > DOLFIN-dev@xxxxxxxxxx
> > > > > > http://www.fenics.org/mailman/listinfo/dolfin-dev
> > > > > 
> > > > _______________________________________________
> > > > DOLFIN-dev mailing list
> > > > DOLFIN-dev@xxxxxxxxxx
> > > > http://www.fenics.org/mailman/listinfo/dolfin-dev
> > > 
> > _______________________________________________
> > DOLFIN-dev mailing list
> > DOLFIN-dev@xxxxxxxxxx
> > http://www.fenics.org/mailman/listinfo/dolfin-dev
>