dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Sat, Dec 02, 2006 at 07:30:13PM +0100, Garth N. Wells wrote:
> > 
> >> One thing to consider is more sophisticated dof mapping. It is worth 
> >> considering a special class to take care of this. This would be useful 
> >> for meshes with mixed cell/element types, parallel assembly and 
> >> computing sparsity patterns.
> > 
> > Yes, we could create a separate class in src/fem/ that takes care of
> > this. Name suggestions: NodeMap, NodeMapping, Nodes, Dofs, DofHandler,
> > ...
> > 
> 
> What about DofHandler or DofManager? I see the class handling the dof 
> mapping, as well as generating sparsity patterns. I'll add something, 
> and start with a function for computing the number of non-zeroes per 
> matrix row (we're overestimating this at the moment substantially which 
> is giving me some memory problems).
> 
> Garth

Sounds good, but I generally don't like class names like FooHandler,
FooManager, FooDirector etc. When you see a lot of classes with those
names in a library, it is often a signal that the design is not optimal.

We have PETScManager, but the only reason it is not named PETSc is
that it collides with something in PETSc. (But maybe it doesn't
anymore, we should check.) I'd like to have PETSc::init() etc.

/Anders


> > FFC generates *one* local-to-global mapping but we are free to reorder
> > what FFC generates. The new class should take input from FFC, reorder
> > it and then make the new ordering accessible during assembly.
> > 
> >> Is there a preference to eventually add partitioning functions in 
> >> src/kernel/mesh, or src/kernel/partition?
> > 
> > I suggest src/kernel/mesh since this is at the same level as
> > refinement and coarsening.
> > 
> > /Anders
> > _______________________________________________
> > DOLFIN-dev mailing list
> > DOLFIN-dev@xxxxxxxxxx
> > http://www.fenics.org/mailman/listinfo/dolfin-dev
> > 
> 
> 
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/dolfin-dev