← Back to team overview

dolfin team mailing list archive

Re: [HG dolfin] Merge.

 

Looks good, but this might not be needed with the UFC-based assembly.

The current BilinearForm interface for evaluation of the element
tensor looks like this:

    void eval(real block[],
              const AffineMap& map,
              real det) const;

but the corresponding UFC interface looks like this:

    void tabulate_tensor(double* A,
                         const double * const * w,
                         const ufc::cell& c) const;

A is the same as block.

w is a list of expansion coefficients for the functions in the form,
and corresponds to the member data c in BilinearForm.

The AffineMap and determinant are no longer arguments to the
tabulate_tensor (eval) function, since they may not be needed, so the
generated code will need to compute the affine map and the determinant
when they are needed.

Perhaps the AffineMap will be needed for other things, but it won't be
needed for the generated code.

/Anders


On Tue, Jan 16, 2007 at 08:53:22PM +0100, DOLFIN wrote:
> One or more new changesets pushed to the primary DOLFIN repository.
> A short summary of the last three changesets is included below.
> 
> changeset:   2582:ca821e1a340902ca2d21d17fb9758258ae703f05
> tag:         tip
> parent:      2581:f69807632a0289522054aa8363f4e2a0dafedc7f
> parent:      2580:f47132a04a539cdacb8fb2ce4435988cfb2d08d2
> user:        "Johan Jansson <johanjan@xxxxxxxxxxxxxxxx>"
> date:        Tue Jan 16 20:40:49 2007 +0100
> files:       src/kernel/fem/Makefile.in src/kernel/fem/dolfin/Makefile.in
> description:
> Merge.
> 
> 
> changeset:   2581:f69807632a0289522054aa8363f4e2a0dafedc7f
> parent:      2574:f5d3bb7327ee9df98b00d6517ef6132fa0ff2a9c
> user:        "Johan Jansson <johanjan@xxxxxxxxxxxxxxxx>"
> date:        Tue Jan 16 20:38:37 2007 +0100
> files:       src/kernel/fem/Makefile.am src/kernel/fem/Makefile.in src/kernel/fem/NewAffineMap.cpp src/kernel/fem/dolfin/Makefile.am src/kernel/fem/dolfin/Makefile.in src/kernel/fem/dolfin/NewAffineMap.h src/kernel/fem/dolfin/dolfin_fem.h src/pydolfin/dolfin_fem.i
> description:
> FEM:
> 
> Added NewAffineMap, a replacement for AffineMap which uses DenseMatrix
> for representation and in addition provides the inverse map.
> 
> 
> changeset:   2580:f47132a04a539cdacb8fb2ce4435988cfb2d08d2
> user:        "Anders Logg <logg@xxxxxxxxx>"
> date:        Tue Jan 16 10:48:30 2007 +0100
> files:       src/bench/fem/assembly/callgrind.out.new src/bench/fem/assembly/callgrind.out.old src/bench/fem/assembly/main.cpp
> description:
> Add (temporarily) callgrind trace files for old and new assembly.
> 
> 
> ----------------------------------------------------------------------
> For more details, visit http://www.fenics.org/hg/dolfin
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/dolfin-dev


Follow ups

References