dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Mon, Aug 18, 2008 at 07:32:35AM +0100, Garth N. Wells wrote:
> 
> 
> Anders Logg wrote:
> > On Sun, Aug 17, 2008 at 11:15:23PM +0200, DOLFIN wrote:
> >> One or more new changesets pushed to the primary dolfin repository.
> >> A short summary of the last three changesets is included below.
> >>
> >> changeset:   4592:b0efa4df44cec1366db459bddf093882bd1eaf1e
> >> tag:         tip
> >> user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
> >> date:        Sun Aug 17 22:14:54 2008 +0100
> >> files:       dolfin/graph/Graph.cpp dolfin/graph/Graph.h dolfin/graph/GraphBuilder.cpp dolfin/graph/GraphBuilder.h dolfin/graph/GraphPartition.cpp dolfin/graph/dolfin_graph.h dolfin/mesh/MeshPartition.cpp dolfin/swig/dolfin_docstrings.i dolfin/swig/dolfin_headers.i
> >> description:
> >> Add class GraphBuilder.
> > 
> > Nice, but shouldn't there be a constructor for Graph that takes a
> > Mesh? It can just call GraphBuilder::build().
> >
> 
> Perhaps, but I'd prefer that the Graph interface be unaware of the Mesh 
> or other object it's built from. GraphBuilder will soon build Graphs 
> from objects other than meshes. Either way, it'll be easy to change 
> whichever way we go.
> 
> Garth

It will be, same as the Mesh class in unaware of how to read XML files.
It's just convenient to have all "create from" methods available as
constructors.

-- 
Anders

Attachment: signature.asc
Description: Digital signature