← Back to team overview

dolfin team mailing list archive

Re: [HG DOLFIN] Merge patch from Shawn Walker

 

ok.  This will probably take me a while to figure out.

Actually, one dumb question I have is for XMLMesh. I noticed the constructor takes a mesh as input:

XMLMesh::XMLMesh(Mesh& mesh) : XMLObject(), _mesh(mesh), state(OUTSIDE), f(0), a(0),
                               mesh_coord(0), xml_vector(0)
{
  // Do nothing

}

My confusion is, why is the mesh argument needed? Because at this point, the mesh hasn't been read in yet. That's what the XMLMesh class does. I realize I am missing something stupid. I guess this is being called from XMLFile?

- Shawn

On Thu, 11 Sep 2008, Anders Logg wrote:

On Thu, Sep 11, 2008 at 04:41:07PM -0400, Shawn Walker wrote:
ok, I see some FIXME's.  I will try and do it better.  I think if I put
the initialization and creation of this higher order mesh_coordinates
function into the MeshEditor class, then that will be better.

- Shawn

Yes, a single setCoordinates() function in both MeshEditor and
MeshGeometry would be good.

And there should probably be two versions of it, one with a reference
and one with a shared_ptr, like we've started to do for the function
classes.

--
Anders



Follow ups

References