← Back to team overview

dolfin team mailing list archive

Re: [HG DOLFIN] Fix assembly over interior facets, DG demo seems to work now

 

Quoting DOLFIN <dolfin@xxxxxxxxxx>:

> One or more new changesets pushed to the primary dolfin repository.
> A short summary of the last three changesets is included below.
> 
> changeset:   5040:14dbf71b2272b246d861b28d38a8cf79cbabadbd
> tag:         tip
> user:        Anders Logg <logg@xxxxxxxxx>
> date:        Tue Oct 28 14:28:50 2008 +0100
> files:       dolfin/fem/Assembler.cpp
> description:
> Fix assembly over interior facets, DG demo seems to work now

Yes indeed. When I was re-writing the main.cpp file for this demo I noticed that
it was easy to get confused about which FunctionSpace to use.

E.g., for u and v I could use one of the following:
PoissonBilinearFormArgumentSpace0
PoissonBilinearFormArgumentSpace1
PoissonLinearFormArgumentSpace0
PoissonLinearFormCoefficientSpace0
PoissonTestSpace
PoissonTrialSpace

and still get the same result. For forms with many functions this only gets
worse. A nice feature would be if one could do:

PoissonFunctionSpace v("v");
PoissonFunctionSpace u("u");
PoissonFunctionSpace n("n");
PoissonFunctionSpace h("h");

or something similar, to be sure that the function space was picked correctly.

Kristian

> 
> changeset:   5039:24ad6216d89b385695e10ac952e7d5dc75e8cac6
> user:        Anders Logg <logg@xxxxxxxxx>
> date:        Tue Oct 28 14:18:51 2008 +0100
> files:       dolfin/function/Function.cpp dolfin/function/Function.h
> dolfin/function/SpecialFunctions.cpp
> description:
> Add Function::on_facet() to deal with Functions defined only on Facets
> 
> 
> changeset:   5038:21049878f469cd6c7e26272164ca6a9d91ec36c3
> user:        "Kristian Oelgaard <k.b.oelgaard@xxxxxxxxxx>"
> date:        Tue Oct 28 11:43:26 2008 +0100
> files:       demo/pde/dg/poisson/cpp/P1Projection.h
> demo/pde/dg/poisson/cpp/Poisson.h demo/pde/dg/poisson/cpp/main.cpp
> dolfin/fem/Form.cpp dolfin/function/SpecialFunctions.cpp
> dolfin/function/SpecialFunctions.h
> description:
> A first try at making the DG demo work. Problems in Function.cpp.
> 
> ----------------------------------------------------------------------
> For more details, visit http://www.fenics.org/hg/dolfin
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/dolfin-dev
> 




Follow ups

References