dolfin team mailing list archive

["Martin Sandve Alnæs" <martinal@xxxxxxxxx>]

This check isn't general either.

   // Test for cell-based element type
-  const uint tdim = mesh.topology().dim();
-  bool only_cell_dofs = dofmap.needs_mesh_entities(tdim);
-  for (uint i = 0; i < tdim; i++)
-  {
-    if (dofmap.needs_mesh_entities(i))
-      only_cell_dofs = false;
-  }
-  if (only_cell_dofs)
+  if( dofmap.local_dimension() == std::pow(mesh.topology().dim(), rank) )
     data_type = "cell";


This is the check I suggested to Anders earlier:

const uint tdim = mesh.topology().dim();
if(dofmap.num_entity_dofs(tdim) == dofmap.local_dimension())

Or hasn't FFC implemented UFC 1.1 yet?

Martin



On Mon, Dec 22, 2008 at 12:42 PM, DOLFIN <dolfin@xxxxxxxxxx> wrote:
> One or more new changesets pushed to the primary dolfin repository.
> A short summary of the last three changesets is included below.
>
> changeset:   5434:d8bb5b439227b34030db2c7682da63a1841924c5
> tag:         tip
> user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
> date:        Mon Dec 22 11:41:53 2008 +0000
> files:       dolfin/io/VTKFile.cpp
> description:
> Change test for cell-based data in VTKFile.
>
> The previous test failed for DG elements of order k > 0.
>
>
> changeset:   5433:b949069baa57b73ac38b88f4b2de1c952c602743
> user:        Johannes Ring <johannr@xxxxxxxxx>
> date:        Mon Dec 22 10:30:47 2008 +0100
> files:       scons/simula-scons/simula_scons/pkgconfiggenerators/gmp.py
> description:
> simula-scons update (added missing cstdlib in GMP test).
>
>
> changeset:   5432:72d035bcc3c234475057ca8f8dfed7cceb5352b7
> user:        Anders Logg <logg@xxxxxxxxx>
> date:        Sun Dec 21 23:27:33 2008 +0100
> files:       dolfin/function/FunctionSpace.cpp dolfin/main/MPI.cpp
> description:
> New attempt to fix bug...
>
> ----------------------------------------------------------------------
> For more details, visit http://www.fenics.org/hg/dolfin
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/dolfin-dev
>