← Back to team overview

dolfin team mailing list archive

Re: [HG DOLFIN] Commented out unimplemented functions and changed uint -> unsigned int

 

On Wednesday 04 March 2009 23:14:54 Ola Skavhaug wrote:
> On Wed, Mar 4, 2009 at 10:59 PM, DOLFIN <dolfin@xxxxxxxxxx> wrote:
> > One or more new changesets pushed to the primary dolfin repository.
> > A short summary of the last three changesets is included below.
> >
> > changeset:   5801:bce61f98970135ef7569e302cc7b6253d869ee04
> > tag:         tip
> > user:        "Johan Hake <hake@xxxxxxxxx>"
> > date:        Wed Mar 04 22:59:54 2009 +0100
> > files:       dolfin/io/File.cpp dolfin/io/File.h
> > description:
> > Commented out unimplemented functions and changed uint -> unsigned int
>
> Thanks for pointing this out, Johan. BTW; why do you change from uint
> to unsigned int? I think uint is used extensively throughout DOLFIN.

No probs :)

For the uint stuff I was a bit unsure actually. First I actually thought the 
methods were implemented but the signature did fit, therefore my naive change 
to unsigned int. Then when I found the error I looked in the file and found 
some unsigned int types, so I did not change back.


Johan

> Ola
>
> > changeset:   5800:61121bc41879e267d3de24416e10343648175f4c
> > user:        "Johan Hake <hake@xxxxxxxxx>"
> > date:        Wed Mar 04 22:36:29 2009 +0100
> > files:       dolfin/io/File.h
> > description:
> > Fixed some typos
> >
> >
> > changeset:   5799:607ad7a34d760692bf1f4f6ebac0e32b0f3dd0b7
> > user:        Anders Logg <logg@xxxxxxxxx>
> > date:        Wed Mar 04 21:57:48 2009 +0100
> > files:       ChangeLog dolfin/function/Function.cpp
> > dolfin/function/Function.h description:
> > Add new constructor to Function class, Function(V, "vector.xml")
> >
> > ----------------------------------------------------------------------
> > For more details, visit http://www.fenics.org/hg/dolfin
> > _______________________________________________
> > DOLFIN-dev mailing list
> > DOLFIN-dev@xxxxxxxxxx
> > http://www.fenics.org/mailman/listinfo/dolfin-dev




Follow ups

References