← Back to team overview

dolfin team mailing list archive

typo in pkg-config generator file of trilinos

 

Hi,

during the compilation of dolfin I realized that a typo in the trilinos.py file prevents the generation of the corresponding pkg-config file when the macro HAVE_ML_NOX is defined. A diff is attached. BTW what do you think about making the pkg-config generation more verbose? Or is there a suitable option? Some of the optional packages were not recognized during the compiling process and a meaningful message why a certain test failed would have been helpful (for instance print the cmdstring and corresponding error message).

Andre
diff -r 15ceb7ed6ff9 scons/simula-scons/simula_scons/pkgconfiggenerators/trilinos.py
--- a/scons/simula-scons/simula_scons/pkgconfiggenerators/trilinos.py	Mon Mar 30 11:01:41 2009 +0200
+++ b/scons/simula-scons/simula_scons/pkgconfiggenerators/trilinos.py	Thu Apr 02 11:23:59 2009 +0200
@@ -114,7 +114,7 @@
 printf("-lml\n");
 
 #ifdef HAVE_ML_NOX
-  printf("-lnox\n")'
+  printf("-lnox\n");
 #endif
 
 #ifdef HAVE_ML_IFPACK

Follow ups