dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Sun, May 10, 2009 at 07:31:55PM +0100, Garth N. Wells wrote:
> 
> 
> Johan Hake wrote:
> > On Sunday 10 May 2009 12:20:24 Garth N. Wells wrote:
> >> DOLFIN wrote:
> >>> One or more new changesets pushed to the primary dolfin repository.
> >>> A short summary of the last three changesets is included below.
> >>>
> >>> changeset:   6112:1b2b19ddacfa92c80d36dc78a5bb4829605a10c0
> >>> tag:         tip
> >>> user:        Anders Logg <logg@xxxxxxxxx>
> >>> date:        Sun May 10 00:33:56 2009 +0200
> >>> files:       dolfin/common/Variable.cpp dolfin/common/Variable.h
> >>> dolfin/log/Logger.cpp dolfin/log/Table.cpp dolfin/log/Table.h
> >>> dolfin/log/log.cpp dolfin/log/log.h dolfin/parameter/NewParameters.cpp
> >>> dolfin/parameter/NewParameters.h sandbox/misc/cpp/main.cpp description:
> >>> Add str() to Variable interface (in C++) and overload info()
> >>> to accept a Variable, printing the output of str().
> >> The function
> >>
> >>      void info(const Variable& variable);
> >>
> >> has caused a problem when compiling the Python wrappers,
> >> dolfin/swig/cpp_wrap.cc: In function ‘PyObject* _wrap_info(PyObject*,
> >> PyObject*)’:
> >> dolfin/swig/cpp_wrap.cc:27939: error: invalid conversion from ‘int’ to
> >> ‘PyObject*’
> >> dolfin/swig/cpp_wrap.cc:27791: error: too many arguments to function
> >> ‘PyObject* _wrap_info__SWIG_0(PyObject*, PyObject*)’
> >> dolfin/swig/cpp_wrap.cc:27939: error: at this point in file
> >> dolfin/swig/cpp_wrap.cc:27942: error: invalid conversion from ‘int’ to
> >> ‘PyObject*’
> >> dolfin/swig/cpp_wrap.cc:27861: error: too many arguments to function
> >> ‘PyObject* _wrap_info__SWIG_1(PyObject*, PyObject*)’
> >> dolfin/swig/cpp_wrap.cc:27942: error: at this point in file
> >> scons: *** [dolfin/swig/cpp_wrap.os] Error 1
> >>
> >>  From a quick inspection, I don't see what the problem is.
> > 
> > I think swig has some problems with overloading functions with variable number 
> > of parameters. 
> 
> I don't particularly like the functions with a variable number of 
> parameters (those using the ellipses (...)). Can we avoid using them? 
> Can we make use of ostringstream instead?

We could do that to some extent, but the current implementation has
some uses:

1. It's consistent with the standard Python logging module which also
has

  info()
  warning()
  error()
  debug()

2. The error() function does not only print an error message, but also
throws an exception (which we can catch in both C++ and Python). It
might look strange if

   dolfin::err << "Unable to open file";

had the same side effect.

3. The debug() function also prints file name, function name and
line number which I don't know how to solve except with a macro.

-- 
Anders

Attachment: signature.asc
Description: Digital signature