← Back to team overview

dolfin team mailing list archive

Re: [HG DOLFIN] Add missing implementation of default_parameters () for ODE (not used).

 

On Monday 11 May 2009 22:45:50 Anders Logg wrote:
> On Mon, May 11, 2009 at 10:10:48PM +0200, Johan Hake wrote:
> > On Monday 11 May 2009 21:54:47 DOLFIN wrote:
> > > One or more new changesets pushed to the primary dolfin repository.
> > > A short summary of the last three changesets is included below.
> > >
> > > changeset:   6131:7e0e10a1f64190120f9f2a5253d12fee4f4c87db
> > > tag:         tip
> > > user:        Anders Logg <logg@xxxxxxxxx>
> > > date:        Mon May 11 21:54:36 2009 +0200
> > > files:       dolfin/ode/ODE.cpp
> > > description:
> > > Add missing implementation of default_parameters() for ODE (not used).
> >
> > I get:
> >
> > dolfin/ode/ODE.cpp:279: error: non-member function ‘dolfin::NewParameters
> > default_parameters()’ cannot have cv-qualifier
>
> That's a bug fix introduced by my bug fix. Should be fixed now.
>
> > > Still problems compiling the Python interface.
> >
> > It is probably the added info(const NewParameters& parameters) that
> > causes this. Should be fixabe in the same way as we did it for
> > info(Variable). Ignore and reimplement in python version.
>
> I get
>
>  dolfin/swig/cpp_wrap.cc
> dolfin/swig/cpp_wrap.cc: In function 'PyObject* _wrap__info(PyObject*,
> PyObject*)':
> dolfin/swig/cpp_wrap.cc:28073: error: invalid conversion from 'int' to
> 'PyObject*'
> dolfin/swig/cpp_wrap.cc:27925: error: too many arguments to function
> 'PyObject* _wrap__info__SWIG_0(PyObject*, PyObject*)'
> dolfin/swig/cpp_wrap.cc:28073: error: at this point in file
> dolfin/swig/cpp_wrap.cc:28076: error: invalid conversion from 'int' to
> 'PyObject*'
> dolfin/swig/cpp_wrap.cc:27995: error: too many arguments to function
> 'PyObject* _wrap__info__SWIG_1(PyObject*, PyObject*)'
> dolfin/swig/cpp_wrap.cc:28076: error: at this point in file
> scons: *** [dolfin/swig/cpp_wrap.os] Error 1
>
> Looks like it has something to do with argc, argv.

Yes swig has problems with overloading methods that uses elipsis, with methods 
that don't. 

> > Will look at it tomorrow.

Should be fixed now.

I also started some initial work on the NewParameter system. It resides in 
dolfin.cpp, and we are not up to par with the c++ functionality yet. I 
probably wont have time to fix everything for the first upcomming realease.

Johan


Follow ups

References