← Back to team overview

dolfin team mailing list archive

Re: [HG DOLFIN] Add call to xmlCleanupParser() in ~SubSystemsManager().

 

On Monday 18 May 2009 01:21:43 DOLFIN wrote:
> One or more new changesets pushed to the primary dolfin repository.
> A short summary of the last three changesets is included below.
>
> changeset:   6181:fbd503991aa11d35c50c142aa26134fdb0888636
> tag:         tip
> user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
> date:        Mon May 18 00:21:03 2009 +0100
> files:       dolfin/log/log.cpp dolfin/main/SubSystemsManager.cpp
> description:
> Add call to xmlCleanupParser() in ~SubSystemsManager().
>
> The means that all but one demo pass the valgrind test (at least if MPI is
> disabled). 

Nice!

We could probably add more suppressions to the dolfin_mpi.supp (and maybe 
rename that file because it not only contains suppressions for mpi), so the 
memory test also pass with mpi.

I have run the memory test on the la/unit/python/test.py and I know that there 
are some issues with the hand made python wrapper of the data() functions for 
matrices. (I fixed this, but forgot to commit it and now an hg update -C has 
removed it.) Will look at it again... 

I also spotted some memory leaks in the Epetra backend, especially in the 
SparsityPattern class.

Should we also run the unit tests through the memory tester?

Johan

> Calling xmlCleanupParser() may cause problems if DOLFIN is 
> called from another program/library which uses libxml2 and
> dolfin::~SubSystemsManager is called while the other program is still
> parsing XML files.
>
>
> changeset:   6180:e53531014e9b3a7859969859c1dd810563424a29
> user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
> date:        Mon May 18 00:10:19 2009 +0100
> files:       dolfin/log/log.cpp
> description:
> Use much simpler solution for leak in plot.cpp.
>
> Use smart pointer boost::scoped_array in place of plain array.
>
>
> changeset:   6179:a8e6beebe5f513687a07d2bf0d652cd83b147f41
> user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
> date:        Sun May 17 23:51:07 2009 +0100
> files:       dolfin/fem/DofMap.cpp dolfin/fem/DofMap.h
> dolfin/function/FunctionSpace.cpp dolfin/log/log.cpp description:
> More DofMap clean up.
>
> ----------------------------------------------------------------------
> For more details, visit http://www.fenics.org/hg/dolfin
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/dolfin-dev




Follow ups

References