dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Sun, May 31, 2009 at 07:46:44PM +0100, Garth N. Wells wrote:
> 
> 
> Anders Logg wrote:
> > On Sun, May 31, 2009 at 03:04:03PM +0100, Garth N. Wells wrote:
> >>
> >> DOLFIN wrote:
> >>> One or more new changesets pushed to the primary dolfin repository.
> >>> A short summary of the last three changesets is included below.
> >>>
> >>> changeset:   6240:93f81aeb4164a199290c0191da93529358de17c6
> >>> tag:         tip
> >>> user:        Anders Logg <logg@xxxxxxxxx>
> >>> date:        Sun May 31 01:31:39 2009 +0200
> >>> files:       demo/ode/courtemanche/cpp/main.cpp demo/ode/harmonic/cpp/main.cpp demo/ode/stiff/cpp/TestProblem1.h demo/ode/stiff/cpp/TestProblem2.h demo/ode/stiff/cpp/TestProblem3.h demo/ode/stiff/cpp/TestProblem4.h demo/ode/stiff/cpp/TestProblem5.h demo/ode/stiff/cpp/TestProblem6.h demo/ode/stiff/cpp/TestProblem7.h demo/ode/stiff/cpp/TestProblem8.h demo/ode/stiff/cpp/TestProblem9.h demo/ode/tentusscher/cpp/tentusscher.h dolfin/common/real.h dolfin/ode/Controller.cpp dolfin/ode/MonoAdaptiveFixedPointSolver.cpp dolfin/ode/MonoAdaptiveNewtonSolver.cpp dolfin/ode/MonoAdaptivity.cpp dolfin/ode/MultiAdaptiveFixedPointSolver.cpp dolfin/ode/MultiAdaptiveNewtonSolver.cpp dolfin/ode/MultiAdaptiveTimeSlab.cpp dolfin/ode/MultiAdaptivity.cpp dolfin/ode/ODE.cpp dolfin/ode/cGqMethod.cpp dolfin/ode/dGqMethod.cpp
> >>> description:
> >>> More work on fixing GMP errors. Math functions moved to real_foo,
> >>> not all with full precision. Still problems with Tentuscher demo.
> >>>
> >> This has broken a lot of functions because 'abs' can't be found. I don't 
> >> know which 'abs' should be called when operating on a 'real'.
> > 
> > Do you have GMP enabled? 
> 
> No.
> 
> I'm currently testing with GMP enabled so I
> > might have missed some things.
> > 
> > For all variables of type real, we need to use real_abs(). In all
> > other cases, it should be std::abs().
> > 
> 
> All the problems I have are on 'abs'. For example,
> 
>    real real_max_abs(uint n, const real* x)
> 
> uses 'abs' which can't be found. Most of the other errors are in the ODE 
> code and quadrature.

ok, I'll take a look.

-- 
Anders

Attachment: signature.asc
Description: Digital signature