← Back to team overview

dolfin team mailing list archive

Re: [HG DOLFIN] Move implementation of some default_parameters functions to .cpp files.

 

On Wed, Jul 08, 2009 at 01:36:51AM +0200, DOLFIN wrote:
> One or more new changesets pushed to the primary dolfin repository.
> A short summary of the last three changesets is included below.
> 
> changeset:   6445:98b0bd7af851ce137e409dbca52a45966c472d85
> tag:         tip
> user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
> date:        Wed Jul 08 00:36:27 2009 +0100
> files:       dolfin/fem/VariationalProblem.h dolfin/la/KrylovSolver.h dolfin/la/LinearSolver.h dolfin/la/PETScKrylovSolver.cpp dolfin/la/PETScKrylovSolver.h dolfin/la/UmfpackLUSolver.cpp dolfin/la/UmfpackLUSolver.h dolfin/la/uBLASKrylovSolver.cpp dolfin/la/uBLASKrylovSolver.h dolfin/parameter/Parameter.cpp dolfin/parameter/Parameter.h dolfin/parameter/Parameters.cpp dolfin/parameter/Parameters.h
> description:
> Move implementation of some default_parameters functions to .cpp files.
> 
> This avoids nasty dependencies and lenthy recompilation.

I originally wanted the parameters to be defined in the header files
to make it simple to see which parameters were available by
inspection, but perhaps it's enough to check parameters by

  info(foo.parameters);

Perhaps we should add a note of this to the header file (class
documentation) of every class that offers parameters. Some standard
text we can reuse:

/// The behavior of this class may be controlled by a set of
/// parameters. The parameters may be listed by either
///
///   info(VariationalProblem::default_parameters());
///
/// or
///
///   info(variational_problem.parameters);
///
/// Only the latter option is available from the DOLFIN Python interface.

-- 
Anders


> changeset:   6444:27b8370cf61c31e66511de5331328a4dcdfadee3
> user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
> date:        Tue Jul 07 22:39:36 2009 +0100
> files:       SConstruct
> description:
> SConstruct fixes. More may be needed.
> 
> 
> changeset:   6443:139dc52bdeb04b6f6d7045b7bc6cf9b1794bd3c0
> user:        Johannes Ring <johannr@xxxxxxxxx>
> date:        Tue Jul 07 23:33:16 2009 +0200
> files:       SConstruct
> description:
> Attempt to fix issue on buildbots.
> 
> ----------------------------------------------------------------------
> For more details, visit http://www.fenics.org/hg/dolfin
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/dolfin-dev

Attachment: signature.asc
Description: Digital signature


Follow ups

References