dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Wed, Aug 12, 2009 at 11:20:15AM +0100, Garth N. Wells wrote:
>
>
> Anders Logg wrote:
> > On Wed, Aug 12, 2009 at 12:10:42PM +0200, Harish Narayanan wrote:
> >> I needed to touch a few files to get a recent clone of the dolfin
> >> repository to compile of my machine. My compiler (mpic++/gcc4.2) doesn't
> >> seem to like default values for boolean variables (verbose) being
> >> specified both in the .cpp and .h files.
> >>
> >> I have attached a bundle removing the default values in the .h files.
> >
> > The default values should only be speficied in the header files (not
> > .cpp), at least that's what my GCC tells me...
> >
>
> Going further on this, I read yesterday that default values should not
> be specified in both the base and derived classes, otherwise evil things
> can happen. If they are specified in the base class, then they should
> not be in the derived class.
>
> Garth

So perhaps we should remove it everywhere except in the Variable base
class?

--
Anders

Attachment: signature.asc
Description: Digital signature