dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Mon, Sep 07, 2009 at 11:28:31AM +0200, Garth N. Wells wrote:
>
>
> Anders Logg wrote:
> > On Mon, Sep 07, 2009 at 10:59:19AM +0200, Garth N. Wells wrote:
> >>
> >> DOLFIN wrote:
> >>> One or more new changesets pushed to the primary dolfin repository.
> >>> A short summary of the last three changesets is included below.
> >>>
> >>> changeset:   6954:b21958b0fdb1fd9dccf3215574e4d0c1d6391644
> >>> tag:         tip
> >>> user:        Anders Logg <logg@xxxxxxxxx>
> >>> date:        Sun Sep 06 22:47:45 2009 +0200
> >>> files:       demo/parameters/cpp/main.cpp demo/parameters/python/demo.py dolfin/parameter/Parameters.cpp test/system/parallel-assembly-solve/test.py
> >>> description:
> >>> Minor fixes in parameter demos and add option --debug to parallel assembly system test.
> >>>
> >> How about a rule that we don't add any new code with old-style C string
> >> function calls? We should be using the C++ stream libraries. We have a
> >> Blueprint for this
> >>
> >>      https://blueprints.launchpad.net/dolfin/+spec/c++-streams
> >>
> >> Garth
> >
> > You mean the sprintf in Parameters.cpp?
>
> Yes.

ok. I don't see a way to avoid it since we're forced to work with
old-style char** rather than std::vector<std::string>.

I've added a note about this to the coding-style chapter in the
manual.

--
Anders


> Garth
>
> I found it hard to avoid since
> > we need to build up a char** to send to PETSc. We need to allocate the
> > char** and we need to copy chars into it.
> >
> >>> changeset:   6953:64435848b6eb09e1458765fb85dbf16e669fec10
> >>> user:        Anders Logg <logg@xxxxxxxxx>
> >>> date:        Sun Sep 06 18:24:17 2009 +0200
> >>> files:       demo/parameters/cpp/main.cpp demo/parameters/python/demo.py sandbox/misc/python/test_params.py
> >>> description:
> >>> Add Python parameter demo.
> >>>
> >>>
> >>> changeset:   6952:a2283cc4b1f34624c6db78d3eb435f3eb531deaf
> >>> user:        Anders Logg <logg@xxxxxxxxx>
> >>> date:        Sun Sep 06 18:11:23 2009 +0200
> >>> files:       dolfin/swig/parameter_post.i
> >>> description:
> >>> Handle real-valued parameters in Python-interface (conversion to float).
> >>>
> >>> ----------------------------------------------------------------------
> >>> For more details, visit http://www.fenics.org/hg/dolfin
> >>> _______________________________________________
> >>> DOLFIN-dev mailing list
> >>> DOLFIN-dev@xxxxxxxxxx
> >>> http://www.fenics.org/mailman/listinfo/dolfin-dev
> >>
> >> _______________________________________________
> >> DOLFIN-dev mailing list
> >> DOLFIN-dev@xxxxxxxxxx
> >> http://www.fenics.org/mailman/listinfo/dolfin-dev
> >>
> >> ------------------------------------------------------------------------
> >>
> >> _______________________________________________
> >> DOLFIN-dev mailing list
> >> DOLFIN-dev@xxxxxxxxxx
> >> http://www.fenics.org/mailman/listinfo/dolfin-dev
>
>
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/dolfin-dev

Attachment: signature.asc
Description: Digital signature