dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Sat, Oct 03, 2009 at 11:12:15PM +0200, DOLFIN wrote:
> One or more new changesets pushed to the primary dolfin repository.
> A short summary of the last three changesets is included below.
>
> changeset:   7244:da48cdfb0ecf
> tag:         tip
> user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
> date:        Sat Oct 03 13:34:09 2009 +0100
> files:       dolfin/function/Data.h
> description:
> Make Data::update public.
>
> The Function design seems to be betting a bit complicated again.

Let's revise it until it's simple enough. The point about the redesign
is to make it simple.

> I just want a function in Coefficient that takes a point and a cell
> and evaluates the function.We have Coefficient::eval(double*,
> Data&), but the necessary functions to constract Data were private.

The point with Data is to keep it simple, in particular to avoid
having many different versions of eval, one when the cell is
available, when it's not, when the facet is available etc etc.

So there are two versions: one with just the point x and another one
that should cover the rest.

> Also, if one calls Coefficient::evaluate(....), the coordinate are
> updated in the Data object (inside Coefficient::evaluate(.)), but
> not the cell.

That's a bug. It should be updated. It should fill out the data with
all information it has: the cell and the coordinates. I'll fix it.
More data may already have been filled into Data, like the current
facet if it's known during assembly (set at the time of calling the
restrict function).

--
Anders

Attachment: signature.asc
Description: Digital signature