← Back to team overview

dolfin team mailing list archive

Re: [HG DOLFIN] Hack in CellSize::eval to get it working again.

 



Anders Logg wrote:
On Thu, Oct 08, 2009 at 10:24:33AM +0200, DOLFIN wrote:
One or more new changesets pushed to the primary dolfin repository.
A short summary of the last three changesets is included below.

changeset:   7330:e013b1723dbe
tag:         tip
user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
date:        Thu Oct 08 09:24:20 2009 +0100
files:       dolfin/function/SpecialFunctions.cpp dolfin/swig/docstrings.i
description:
Hack in CellSize::eval to get it working again.

Looks pretty good.

I've thrown away the mesh test.

I think we should add another member named "index"
to the ufc::cell class for convenience/speed. It's possible to get the
cell index by accessing entity_indices[topological_dimension][0] but
it's somewhat cumbersome:

https://blueprints.launchpad.net/ufc/+spec/add-index-to-cell

Problem caused by the invalidate call in Data. Perhaps we should gave

  Data::reset(....) // Invalidate and then update data
  Data::add(....)   // Add data

in place of Data::update. Data::

How about reset() and update()?


I didn't use 'update' because it's not clear to me from the name whether or not it should invalidate data that's not being updated. I'm not too fussed though.

Garth


--
Anders

changeset:   7329:afadea9429c1
user:        "Garth N. Wells <gnw20@xxxxxxxxx>"
date:        Wed Oct 07 22:57:23 2009 +0100
files:       dolfin/function/Function.cpp
description:
Fix a constructor in Function.


changeset:   7328:a5b8bd518351
user:        "Johan Hake <hake@xxxxxxxxx>"
date:        Wed Oct 07 23:49:10 2009 +0200
files:       site-packages/dolfin/compile_expressions.py site-packages/dolfin/function.py
description:
Fix sub function extraction in PyDOLFIN
  - However something is wrong. stokes (Taylor-Hood) triggers an assertion in
    Function.cpp:443

----------------------------------------------------------------------
For more details, visit http://www.fenics.org/hg/dolfin
_______________________________________________
DOLFIN-dev mailing list
DOLFIN-dev@xxxxxxxxxx
http://www.fenics.org/mailman/listinfo/dolfin-dev

------------------------------------------------------------------------

_______________________________________________
DOLFIN-dev mailing list
DOLFIN-dev@xxxxxxxxxx
http://www.fenics.org/mailman/listinfo/dolfin-dev


Follow ups

References