← Back to team overview

dolfin team mailing list archive

Re: Array<double> in SubDomain::inside()

 


Johan Hake wrote:
> Hello!
> 
> I am trying to close the Array typemap Blueprint.
> 
> Is it worth changing the double* x/y arguments in SubDomain methods to Array? 
> The pros would be to have a consistent Python interface, but it makes things 
> more difficult in the C++ implementation.
>

What makes it difficult on the C++ side?

> We could maybe add an Array version of the different methods of SubDomain
> 
>   inside, map, snap
> 
> Then can the double * version of the same methods call the Array version by 
> default. Then we only expose the Array version to Python.
>

I would prefer to have dolfin::Array versions only, if possible.

> This is not a big deal as it is working fine as it is, but would be good to 
> get rid of most of the double * typemaps.
>

Yes. It would be good to remove all plain array arguments in the public
interface in favour of safer types.

Garth


> Johan
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References