dolfin team mailing list archive

["Garth N. Wells" <gnw20@xxxxxxxxx>]

On 06/04/10 01:28, Anders Logg wrote:
> Applied (with only minor changes).
>
> I had to change DEBUG to DGG since the build system sets the flag
> -DDEBUG when compiling.
>
> Would it be better to change that flag to -DDOLFIN_DEBUG?

We should encourage/require contributors place their code on Launchpad 
and request a merge. That way we can test changes before they become 
part of dolfin-dev  and provide feedback if necessary.

Garth

> --
> Anders
>
>
> On Fri, Mar 26, 2010 at 12:43:20PM +0100, Anders Logg wrote:
> > Attached is a patch from Joachim containing some improvements to the
> > log system. I think it looks good, and it matches the Python logging
> > system quite well (which we use from UFL and FFC).
> >
> > I'll comment more on it later and apply the patch.