dolfin team mailing list archive

[Johannes Ring <johannr@xxxxxxxxx>]

On Tue, Aug 10, 2010 at 6:16 PM, Anders Logg <logg@xxxxxxxxx> wrote:
> On Tue, Aug 10, 2010 at 06:02:56PM +0200, Johannes Ring wrote:
>> On Tue, Aug 10, 2010 at 5:47 PM,  <noreply@xxxxxxxxxxxxx> wrote:
>> > ------------------------------------------------------------
>> > revno: 4932
>> > committer: Anders Logg <logg@xxxxxxxxx>
>> > branch nick: dolfin-dev
>> > timestamp: Tue 2010-08-10 17:33:10 +0200
>> > message:
>> >  Export link directories from UMFPACK configure script. Does not seem to
>> >  work but perhaps the problem is they are not exported correctly to the
>> >  dolfin.pc file?
>> > modified:
>> >  cmake/FindUMFPACK.dolfin.cmake
>> >
>> >
>> >
>> > Your team DOLFIN Core Team is subscribed to branch lp:dolfin.
>> > To unsubscribe from this branch go to https://code.launchpad.net/~dolfin-core/dolfin/main/+edit-subscription
>> >
>> > === modified file 'cmake/FindUMFPACK.dolfin.cmake'
>> > --- cmake/FindUMFPACK.dolfin.cmake      2010-08-10 14:20:41 +0000
>> > +++ cmake/FindUMFPACK.dolfin.cmake      2010-08-10 15:33:10 +0000
>> > @@ -69,6 +69,7 @@
>> >   message("   Found package 'UMFPACK'")
>> >   set(UMFPACK_FOUND 1)
>> >   include_directories(${UMFPACK_INCLUDE_DIR})
>> > +  link_directories(${UMFPACK_LIBRARY})
>> >   add_definitions(-DHAS_UMFPACK)
>>
>> As Garth said, this is not the right way to do it. The FindXXX.cmake
>> files should only define variables and then they can be used
>> elsewhere.
>
> ok, I just tried to follow his example for the MTL4 configure script.

Yes, I know :-)

Johannes

> --
> Anders
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAkxhe2IACgkQTuwUCDsYZdEQGACfVcXt0QuHN7iTSbJsOTd6ITtl
> KAUAn2KeqZAjX4xAE99X4/Jr4KrAbhLt
> =Xsak
> -----END PGP SIGNATURE-----
>
>