dolfin team mailing list archive

[Johannes Ring <johannr@xxxxxxxxx>]

On Fri, Aug 20, 2010 at 10:52 AM, Garth N. Wells <gnw20@xxxxxxxxx> wrote:
> On Fri, 2010-08-20 at 10:23 +0200, Anders Logg wrote:
>> On Fri, Aug 20, 2010 at 10:02:58AM +0200, Johannes Ring wrote:
>> > On Thu, Aug 19, 2010 at 9:31 PM,  <noreply@xxxxxxxxxxxxx> wrote:
>> > > ------------------------------------------------------------
>> > > revno: 5032
>> > > committer: Anders Logg <logg@xxxxxxxxx>
>> > > branch nick: dolfin
>> > > timestamp: Thu 2010-08-19 21:28:38 +0200
>> > > message:
>> > >  Add extra includes for Boost used by Armadillo test, not sure if this
>> > >  is the right way.
>> >
>> > I think it is better if we use the Boost_INCLUDE_DIR variable defined
>> > by the FindBoost module. We should either call find_package(Boost) in
>> > FindArmadillo or assume that Boost_INCLUDE_DIR has already been
>> > defined. The latter requires the find_package(Boost...) statement (in
>> > CMakeLists.txt) to be moved before the call to
>> > find_package(Armadillo...).
>>
>
> It's probably best to call find_package(Boost . .. ) from inside
> FindArmadillo.cmake so that FindArmadillo.cmake is stand-alone.

Yes, I agree. I will fix it.

Johannes

> We should still call find_package(Boost . . . ) from CMakeLists.text.
>
> Garth
>
>> That sounds good to me! Just go ahead an fix it.
>>
>> --
>> Anders
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dolfin
>> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dolfin
>> More help   : https://help.launchpad.net/ListHelp
>
>
>