dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Mon, Aug 23, 2010 at 01:49:56PM +0100, Garth N. Wells wrote:
> On Mon, 2010-08-23 at 14:44 +0200, Anders Logg wrote:
> > On Mon, Aug 23, 2010 at 01:40:40PM +0100, Garth N. Wells wrote:
> > > On Mon, 2010-08-23 at 14:26 +0200, Anders Logg wrote:
> > > > On Mon, Aug 23, 2010 at 01:10:56PM +0100, Garth N. Wells wrote:
> > > > > On Mon, 2010-08-23 at 10:34 +0000, noreply@xxxxxxxxxxxxx wrote:
> > > > > > ------------------------------------------------------------
> > > > > > revno: 5057
> > > > > > committer: Anders Logg <logg@xxxxxxxxx>
> > > > > > branch nick: dolfin-dev
> > > > > > timestamp: Mon 2010-08-23 12:31:46 +0200
> > > > > > message:
> > > > > >   Collect optional packages in OPTIONAL_PACKAGES and use to set options.
> > > > >
> > > > > I think that this should changed this back. It's nice to be able to
> > > > > enable/disable packages from the GUI, and it's nice to have a
> > > > > descriptive string.
> > > >
> > > > It's still possible to change from the GUI.
> > >
> > > OK.
> > >
> > >
> > > > It should be possible to
> > > > add the strings back but they weren't very informative. They pretty
> > > > much said the same thing all of them.
> > >
> > > We can make them more informative.
> > >
> > > >
> > > > The OPTIONAL_PACKAGES variable makes it possible to write a nice
> > > > summary at the end.
> > >
> > >
> > > This isn't working properly - it converts everything to upper case, so
> > > when it should be checking for Trilinos_FOUND and not TRILINOS_FOUND.
> >
> > Looks to me like the problem is that variable has the wrong name. It
> > should be named TRILINOS_FOUND.
> >
>
> It takes on part of the name of the file, which TrilinosConfig.cmake.

Are you sure?

We have FindPETSc.cmake but it still defines PETCS_FOUND. We even send
in "PETSc" to find_package_handle_standard_args and it still comes out
as PETSC_FOUND.

I think find_package_handle_standard_args automatically sets uppercase
but this is not used by the Trilinos config script.

--
Anders


> Garth
>
> > The conversion to uppercase is to make it possible to have the help
> > text say
> >
> >   "Compile with support for PETSc"
> >
> > instead of PETSC.
> >
>
>

--
Anders