dolfin team mailing list archive

["Garth N. Wells" <gnw20@xxxxxxxxx>]

On 24/08/10 13:21, Johannes Ring wrote:
> On Tue, Aug 24, 2010 at 2:19 PM, Garth N. Wells <gnw20@xxxxxxxxx> wrote:
>>
>>
>> On 24/08/10 13:19, Johannes Ring wrote:
>>> On Tue, Aug 24, 2010 at 2:14 PM, Garth N. Wells <gnw20@xxxxxxxxx> wrote:
>>>>
>>>>
>>>> On 24/08/10 13:09, Johannes Ring wrote:
>>>>> On Tue, Aug 24, 2010 at 1:52 PM,  <noreply@xxxxxxxxxxxxx> wrote:
>>>>>> ------------------------------------------------------------
>>>>>> revno: 5094
>>>>>> committer: Garth N. Wells <gnw20@xxxxxxxxx>
>>>>>> branch nick: dolfin-cmake
>>>>>> timestamp: Tue 2010-08-24 12:48:37 +0100
>>>>>> message:
>>>>>>  Remove HINTS and stanard paths from CHOLMOD test.
>>>>>
>>>>> This doesn't allow me to do
>>>>>
>>>>>   cmake -DCHOLMOD_DIR=/path/to/cholmod ..
>>>>>
>>>>> which I like better than defining environment variables before running
>>>>> cmake. Can't we allow both?
>>>>>
>>>>
>>>> I removed 'HINTS' because the CMake docs advise against this type of
>>>> usage (they say HINTS should be used as a helper based on something else
>>>> which has been discovered, e.g. an include dir).
>>>
>>> Ok.
>>>
>>>> I expect that there's another way to point CMake in the right direction.
>>>
>>> Yes, ${CHOLMOD_DIR} (in addition to $ENV{CHOLMOD_DIR}) can be added to
>>> PATH in find_library (or find_path). Is it okay to do that?
>>>
>>
>> Looks good to me. We should to it for all the packages.
> 
> Ok, I'll do that.
> 

I guess ${CHOLMOD_DIR} should come before $ENV{CHOLMOD_DIR} (priority
for the command line argument)?

Garth

> Johannes
> 
>> Garth
>>
>>> Johannes
>>>
>>>> Garth
>>>>