dolfin team mailing list archive

["Marie E. Rognes" <meg@xxxxxxxxx>]

On 01/05/2011 03:32 PM, Garth N. Wells wrote:
> I wonder if the distinction now between linear and nonlinear problems 
> is too subtle? Another way would be to have classes
>
>   LinearVariationalProblem
>
> and
>
>   NonlinearVariationalProblem


I agree that the distinction in the interface can be called subtle (or 
alternatively, "almost seamless"). But, I think I prefer keeping the 
input minimal and rather giving more verbose feedback ("starting 
linear/nonlinear solve", throwing errors if input is inconsistent etc) 
than increasing the verbosity of the required input.

Also cf. thread "VariationalProblem interface(s)" from Oct 20th for more 
motivation behind this change.

--
Marie

> Garth
>
> On 05/01/11 13:44, noreply@xxxxxxxxxxxxx wrote:
> > ------------------------------------------------------------
> > revno: 5463
> > committer: Marie E. Rognes<meg@xxxxxxxxx>
> > branch nick: dolfin
> > timestamp: Wed 2011-01-05 14:30:36 +0100
> > message:
> >    Change VariationalProblem interface.
> >
> >           VariationalProblem(F, dF, bcs, cell_domains, ...)
> >           VariationalProblem(a,  L  bcs, cell_domains, ...)
> >
> >    In essense, removed nonlinear=true/false argument, and swapped the
> >    order of the first two arguments for nonlinear problems.
> >
> >    Some redesign remaining to get the python version to accept
> >
> >           VariationalProblem(F, bcs=...)
> > modified:
> >    ChangeLog
> >    demo/pde/hyperelasticity/cpp/main.cpp
> >    demo/pde/hyperelasticity/python/demo.py
> >    demo/undocumented/nonlinear-poisson/cpp/main.cpp
> >    demo/undocumented/nonlinear-poisson/python/demo.py
> >    dolfin/fem/VariationalProblem.cpp
> >    dolfin/fem/VariationalProblem.h
> >    dolfin/swig/docstrings.i
> >    site-packages/dolfin/fem/variationalproblem.py
> > The size of the diff (1254 lines) is larger than your specified limit 
> > of 1000 lines
> >
> > --
> > lp:dolfin
> > https://code.launchpad.net/~dolfin-core/dolfin/main
> >
> > Your team DOLFIN Core Team is subscribed to branch lp:dolfin.
> > To unsubscribe from this branch go to 
> > https://code.launchpad.net/~dolfin-core/dolfin/main/+edit-subscription
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp