← Back to team overview

dolfin team mailing list archive

Re: [Branch ~dolfin-core/dolfin/main] Rev 5731: Remove parts of pointer/reference interface in Form. Prefer shared_ptr interfaces instead.

 

On 03/06/2011 10:41 PM, Garth N. Wells wrote:


On 06/03/11 21:29, Marie E. Rognes wrote:
On 03/06/2011 10:22 PM, Anders Logg wrote:
On Sun, Mar 06, 2011 at 09:08:10PM +0000, Garth N. Wells wrote:


On 06/03/11 21:02, Marie E. Rognes wrote:
On 03/06/2011 09:30 PM, noreply@xxxxxxxxxxxxx wrote:
      if (parameters["max_dimension"].change_count()>    0
          &&    V.dim()>    max_dimension)
+  {
        return true;
-
-  // Otherwise, not done.
-  return false;
+  }
+  else
+    return false;
    }


I notice that my early returns keep getting moved into else
clauses... I
find this approach less readable, especially when there are nested ifs.
Why is it the preferred way?


Because your comment basically says else, so I'd say it's better to have
the code say it consistently.

I find it easier to follow, because it's clear that the function exits
from the conditional block. The return value is either true or false
depending on the one true/false evaluation.


The code is an if -- else if -- else. I don't see how moving that into
an if, if -- else increases consistency.


It was an if -- else.


No, it was not. (It was an "done if A", "done if B", otherwise "not done")

The example in question was pretty trivial, and its precise form not a big deal. However, I think having a common policy would be beneficial.

--
Marie






Follow ups

References