dolfin team mailing list archive

["Garth N. Wells" <gnw20@xxxxxxxxx>]

On 29/03/11 00:27, Johan Hake wrote:
> On Monday March 28 2011 15:17:02 Anders Logg wrote:
>> On Mon, Mar 28, 2011 at 03:13:42PM -0700, Johan Hake wrote:
>>> On Monday March 28 2011 14:56:16 Anders Logg wrote:
>>>> On Mon, Mar 28, 2011 at 02:32:02PM -0700, Johan Hake wrote:
>>>>> On Monday March 28 2011 14:20:33 Anders Logg wrote:
>>>>>> We're getting closer. Please have a look and fix your 
> bugs/blueprints:
>>>>> I would like to postpone:
>>>>>   https://bugs.launchpad.net/bugs/681415
>>>>>
>>>>> as the suggested solution need a larger revamp of the interface than,
>>>>> at least I am comfident in getting in place for the next release.
>>>>
>>>> Maybe then it's better to postpone the release? It would be good to
>>>> get all interface changes in place before a release that precedes 1.0.
>>>
>>> No strong feelings about this. But I think it should be ok to change such
>>> a comparable small interface change before the 1.0 release.
>>
>> I thought you just said it was a "large revamp of the interface". ;-)
> 
> I guess I emphasized 'larger' a bit too much, together with including the word 
> 'interface' :) 
> 
> My point is that it takes some changes in the C++ implementation if extraction 
> of SubSpaces, which I am not up to. 
> 
>> My point is that if you feel uncomfortable about the change, it's
>> better we make it sooner rather than later so we have a chance to test
>> it before 1.0.
> 
> Fine with me, but I probably need either Garth or you to team up with.
>  

I've added a basic framework to get started on this. A class
GenericFunctionSpace has been added, and FunctionSpace is a subclass of
this. The boundary condition classes work with GenericFunctionSpaces.

What remains is to make SubSpace a subclass of GenericFunctionSpace
(rather than of FunctionSpace) and have the 'extract_subspace' functions
return SubSpaces. From then on it should be a questions of straightening
things out, e.g. add a constructor

  FunctionSpace::FunctionSpace(const SubSpace& V)

that 'collapses' a function space.

Garth

> Johan
> 
>> --
>> Anders
>>
>>> The proposed changes also need to be implemented in C++ where I guess
>>> others (TM) need to step in.
>>>
>>> Johan
>>>
>>>> Or we could do 0.9.12 before 1.0.
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dolfin
>> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dolfin
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp