dolfin team mailing list archive

["Garth N. Wells" <gnw20@xxxxxxxxx>]

>From a quick look, this code needs some fixes:

 - Remove use of 'new' with plain pointers. We've made an effort to
remove 'new' from throughout the library.

 - Use the DOLFIN convention for one line control statements

 - Use more meaningful names (something better than, for example,
glob2loc, lci)

 - Do not use MeshData for parallel data

 - There are missing check on pointers which may lead to memory leaks.

Garth


On 30/05/11 14:30, noreply@xxxxxxxxxxxxx wrote:
> ------------------------------------------------------------
> revno: 5902
> committer: Kent-Andre Mardal <kent-and@xxxxxxxxx>
> branch nick: dolfin
> timestamp: Mon 2011-05-30 15:27:52 +0200
> message:
>   minor cleanup
> modified:
>   test/unit/bc-indicators/python/aneurysm.py
> 
> 
> --
> lp:dolfin
> https://code.launchpad.net/~dolfin-core/dolfin/main
> 
> Your team DOLFIN Core Team is subscribed to branch lp:dolfin.
> To unsubscribe from this branch go to https://code.launchpad.net/~dolfin-core/dolfin/main/+edit-subscription