← Back to team overview

dolfin team mailing list archive

Re: Patch adding support for gmsh physical markers on facets

 


On 24/06/11 08:56, Evan Lezar wrote:
> Garth
> 
> I am busy finalising the tests and will send them through in an hour or so.
>

Great. Better than sending a patch to the mailing list is to push a
branch to Launchpad

  bzr push lp~user-name/dolfin/your-branch-name

and request a merge. That way there's not chance of the patch getting
lost on the mailing list.

Garth


> Evan
> 
> On Jun 24, 2011 4:46 PM, "Garth N. Wells" <gnw20@xxxxxxxxx
> <mailto:gnw20@xxxxxxxxx>> wrote:
>> Could you add some simple tests to
>>
>> test/unit/meshconvert/python/test.py
>>
>> in the patch?
>>
>> Garth
>>
>> On 24/06/11 07:33, Evan Lezar wrote:
>>> Hi
>>>
>>> Please find a small patch with modifications to meshconvert.py that
>>> allows for the handling of facet physical regions using gmsh. This is
>>> done in much the same way as the existing physical region (for cells)
>>> support.
>>>
>>> I am working on a few test cases, but at least the existing meshconvert
>>> test cases do not fail :)
>>>
>>> Please let me know if there are any questions or comments.
>>>
>>> Evan
>>> --
>>> www.evanlezar.com <http://www.evanlezar.com> <http://www.evanlezar.com>
>>>
>>> GoogleTalk: evanlezar
>>> Skype: evanlezar
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~dolfin
>>> Post to : dolfin@xxxxxxxxxxxxxxxxxxx <mailto:dolfin@xxxxxxxxxxxxxxxxxxx>
>>> Unsubscribe : https://launchpad.net/~dolfin
>>> More help : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dolfin
>> Post to : dolfin@xxxxxxxxxxxxxxxxxxx <mailto:dolfin@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~dolfin
>> More help : https://help.launchpad.net/ListHelp


References