dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Fri, Jul 01, 2011 at 02:10:50PM +0200, Marie E. Rognes wrote:
> On 07/01/11 13:13, Anders Logg wrote:
> >On Fri, Jul 01, 2011 at 11:07:15AM +0200, Martin Sandve Alnæs wrote:
> >>On 1 July 2011 09:05, Anders Logg<logg@xxxxxxxxx>  wrote:
> >>>They are always generated as it is now, but I assume it would be
> >>>simple to make it so that they are only generated if they are used.
> >>>
> >>>I'm not sure there's a big chance they will be misunderstood. Users
> >>>will not know that the classes ResidualForm and JacobianForm are
> >>>defined if they don't read through the generated code. Users will only
> >>>know about them if they look at a nonlinear example and then it will
> >>>be clear how they should be used.
> >>Users rarely follow the train of thought they're supposed to :)
> >>
> >>I don't have a strong opinion either, do as you like.
> >ok. :-)
> >
>
> Always interpreting F and J as a linear and bilinear form without
> adding more checks is slightly error-prone cf the failing FFC
> buildbot.

I have added a check now in UFL that F and J are only recognized as
forms when not {a and L are defined}. It would be easy to change that
'and' to an 'or' if we need to.

The FFC buildbot should be green soon.

--
Anders