dolfin team mailing list archive

[Martin Sandve Alnæs <martinal@xxxxxxxxx>]

On 11 November 2011 00:13, Anders Logg <logg@xxxxxxxxx> wrote:
> On Thu, Nov 10, 2011 at 11:15:55PM +0100, Martin Sandve Alnæs wrote:
>> On 10 November 2011 22:50, Garth N. Wells <gnw20@xxxxxxxxx> wrote:
>> > Depends how quickly they can be fixed. Fine with me if fixed quickly, but best commented out  + bug report registered if the fix will take some time.
>>
>> Yes, that's my opinion as well. Quick fix is often fine, but IMHO
>> quick < an hour.
>
> I think up to say 4 hours is reasonable, but I'll try to stick to 1
> hour.

And I thought I was generous when saying 1 hour :)

In fact, I think the choices are basically revert ASAP, or potentially
occupy the buildserver for the day. Even taking one hour to fix will
easily lead to half a workday between first checkin and all green again.
So I guess I usually won't care if it's 1 or 4 hours, I'll just wait a
day anyway.


>> It's a matter of economy: one developer breaking the tests
>> potentially disrupts the workflow of several other developers.
>
> That's why we have the personal buildbots so the above never happens.

That too, but I'd rather say we have the personal buildbots to ensure
broken builds are not pushed to the central branch in the first place.
When I've checked out 1.0.x, built, and run tests, then discover
they're broken, I've already waited an hour.


> My personal buildbot has given a timeout 9 out of the 10 last times
> I've used it so I haven't really been able to use it. And the last
> time I used it, the timeout happened to be caused by a slow unit test
> that I added... We are buying a new and faster machine to run some
> buildbots so this should improve.

We need faster tests... Maybe they can be split into fast/slow ones,
reported separately? After 1.0 is out, I suggest we discuss ways to
improve the tests and buildbot.


>> And a number of tests still fail locally here, for example (several of
>> each of these):
>
> That's strange. Those are the ones I just fixed:

Sorry, strange, I probably failed to install between checking out and
running make runtests.


> We should really get the buildbots to do partial rebuild without
> instant-clean. If it takes more than 2 hours to rebuild, that's also
> disruptive to the workflow.

Agree very much.

Martin