← Back to team overview

dolfin team mailing list archive

Re: [Branch ~dolfin-core/dolfin/1.0.x-logg] Rev 6410: Work on error --> dolfin_error conversion, only 400 remaining...

 


On 14 Nov 2011, at 20:07, Anders Logg <logg@xxxxxxxxx> wrote:

> On Mon, Nov 14, 2011 at 10:32:06AM -0800, Johan Hake wrote:
>> Are you covering the error, RuntimeErrors, raised in the Python layer too?
> 
> I'm not sure yet... It's quite exhausting.
> 
>> If not what should our policy be for these. I think there is a fine mix of
>> different errors being raised there.
> 
> Is there any problem in calling cpp.dolfin_error from the Python
> files? That would give the most uniform handling of
> errors. dolfin_error should ultimately throw an exception which can
> be caught from Python.
> 

I recall that we discussed catching errors in Python before and there were some issues. Johan?

Garth


> --
> Anders
> 
> 
>> Johan
>> 
>> On Monday November 14 2011 10:23:18 noreply@xxxxxxxxxxxxx wrote:
>>> ------------------------------------------------------------
>>> revno: 6410
>>> committer: Anders Logg <logg@xxxxxxxxx>
>>> branch nick: 1.0.x-dolfin_error
>>> timestamp: Mon 2011-11-14 19:20:22 +0100
>>> message:
>>>  Work on error --> dolfin_error conversion, only 400 remaining...
>>> modified:
>>>  dolfin/adaptivity/ErrorControl.cpp
>>>  dolfin/adaptivity/Extrapolation.cpp
>>>  dolfin/adaptivity/TimeSeries.cpp
>>>  dolfin/adaptivity/adapt.cpp
>>>  dolfin/adaptivity/marking.cpp
>>>  dolfin/ale/ALE.cpp
>>>  dolfin/ale/HarmonicSmoothing.cpp
>>>  dolfin/common/Array.h
>>>  dolfin/common/MPI.cpp
>>>  dolfin/common/MPI.h
>>>  dolfin/common/SubSystemsManager.cpp
>>>  dolfin/common/timing.cpp
>>>  dolfin/fem/Assembler.cpp
>>>  dolfin/fem/AssemblerTools.cpp
>>>  dolfin/fem/BoundaryCondition.cpp
>>>  dolfin/fem/DirichletBC.cpp
>>>  dolfin/fem/DofMap.cpp
>>>  dolfin/fem/DofMapBuilder.cpp
>>>  dolfin/fem/FiniteElement.cpp
>>>  dolfin/fem/Form.cpp
>>>  dolfin/fem/OpenMpAssembler.cpp
>>>  dolfin/fem/PeriodicBC.cpp
>>>  dolfin/fem/PointSource.cpp
>>>  dolfin/fem/SparsityPatternBuilder.cpp
>>>  dolfin/fem/SystemAssembler.cpp
>>>  dolfin/fem/UFCCell.h
>>>  dolfin/fem/assemble.cpp
>>>  dolfin/function/Constant.cpp
>>>  dolfin/function/Expression.cpp
>>>  dolfin/function/Function.cpp
>>>  dolfin/function/FunctionSpace.cpp
>>>  dolfin/function/GenericFunction.cpp
>>>  dolfin/graph/GraphColoring.cpp
>>>  dolfin/graph/MatrixRenumbering.cpp
>>>  dolfin/graph/ParMETIS.cpp
>>>  dolfin/graph/SCOTCH.cpp
>>>  dolfin/graph/ZoltanInterface.cpp
>>>  dolfin/io/BinaryFile.cpp
>>>  dolfin/io/Encoder.h
>>>  dolfin/io/File.cpp
>>>  dolfin/io/GenericFile.cpp
>>>  dolfin/io/RAWFile.cpp
>>>  dolfin/io/SAX2AttributeParser.h
>>>  dolfin/io/VTKFile.cpp
>>>  dolfin/io/VTKWriter.cpp
>>>  dolfin/io/XMLArray.h
>>>  dolfin/io/XMLFile.cpp
>>>  dolfin/io/XMLFunctionData.cpp
>>>  dolfin/io/XMLFunctionPlotData.cpp
>>>  dolfin/io/XMLLocalMeshSAX.cpp
>>> The size of the diff (3285 lines) is larger than your specified limit of
>>> 500 lines
>>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dolfin
>> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dolfin
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References