← Back to team overview

dolfin team mailing list archive

Re: [Branch ~dolfin-core/dolfin/1.0.x-logg] Rev 6410: Work on error --> dolfin_error conversion, only 400 remaining...

 

On Mon, Nov 14, 2011 at 09:52:41PM +0100, Marie E. Rognes wrote:
> On 11/14/2011 09:07 PM, Anders Logg wrote:
> >On Mon, Nov 14, 2011 at 10:32:06AM -0800, Johan Hake wrote:
> >>Are you covering the error, RuntimeErrors, raised in the Python layer too?
> >I'm not sure yet... It's quite exhausting.
>
> Want to delegate parts?

Oh yes! That would leave me time to go after some bugs instead.

I'll merge what I have now into 1.0.x as soon as my buildbot is green
(or more likely when it times out).

I'll be adding some instructions for how to use dolfin_error in log.h.

And here's a bit of help:

# edit all files needing editing

for f in `find dolfin -name '*.cpp' -o -name '*.h' | grep -v Poisson \
 | xargs grep "\berror(" | cut -d':' -f1 | sort | uniq`; do emacs $f; done

# check number of remaining edits:

find dolfin -name '*.cpp' -o -name '*.h' | grep -v Poisson \
 | xargs grep "\berror" | wc

Have fun, and thanks a bunch!!! What a relief.

--
Anders


Follow ups

References