dolfin team mailing list archive

Thread
Date

Fwd: [Branch ~dolfin-core/dolfin/trunk] Rev 6467: Change return value of IntervalCell::facet_area() 0.0 --> 1.0.

To: DOLFIN Mailing List <dolfin@xxxxxxxxxxxxxxxxxxx>
From: "Garth N. Wells" <gnw20@xxxxxxxxx>
Date: Tue, 29 Nov 2011 10:16:16 +0000
In-reply-to: <20111124124316.4631.27817.launchpad@ackee.canonical.com>

Should this change have gone into the 1.0 branch rather than trunk?

Garth


---------- Forwarded message ----------
From:  <noreply@xxxxxxxxxxxxx>
Date: 24 November 2011 12:43
Subject: [Branch ~dolfin-core/dolfin/trunk] Rev 6467: Change return
value of IntervalCell::facet_area() 0.0 --> 1.0.
To: Garth Wells <gnw20@xxxxxxxxx>


------------------------------------------------------------
revno: 6467
committer: Kristian B. Ølgaard <k.b.oelgaard@xxxxxxxxx>
branch nick: dolfin
timestamp: Thu 2011-11-24 13:39:12 +0100
message:
 Change return value of IntervalCell::facet_area() 0.0 --> 1.0.

 This is consistent with the output of a form 1*ds on an interval.
modified:
 ChangeLog
 dolfin/mesh/IntervalCell.cpp


--
lp:dolfin
https://code.launchpad.net/~dolfin-core/dolfin/trunk

Your team DOLFIN Core Team is subscribed to branch lp:dolfin.
To unsubscribe from this branch go to
https://code.launchpad.net/~dolfin-core/dolfin/trunk/+edit-subscription

=== modified file 'ChangeLog'
--- ChangeLog   2011-11-22 10:25:14 +0000
+++ ChangeLog   2011-11-24 12:39:12 +0000
@@ -1,3 +1,4 @@
+ - Change return value of IntervalCell::facet_area() 0.0 --> 1.0.
 1.0-rc1 [2011-11-21]
 - 33 bugs fixed
 - Implement traversal of bounding box trees for all codimensions

=== modified file 'dolfin/mesh/IntervalCell.cpp'
--- dolfin/mesh/IntervalCell.cpp        2011-11-22 23:36:21 +0000
+++ dolfin/mesh/IntervalCell.cpp        2011-11-24 12:39:12 +0000
@@ -178,7 +178,7 @@
 //-----------------------------------------------------------------------------
 double IntervalCell::facet_area(const Cell& cell, uint facet) const
 {
-  return 0.0;
+  return 1.0;
 }
 //-----------------------------------------------------------------------------
 void IntervalCell::order(Cell& cell,

=== modified file 'ChangeLog'
--- ChangeLog	2011-11-22 10:25:14 +0000
+++ ChangeLog	2011-11-24 12:39:12 +0000
@@ -1,3 +1,4 @@
+ - Change return value of IntervalCell::facet_area() 0.0 --> 1.0.
 1.0-rc1 [2011-11-21]
  - 33 bugs fixed
  - Implement traversal of bounding box trees for all codimensions

=== modified file 'dolfin/mesh/IntervalCell.cpp'
--- dolfin/mesh/IntervalCell.cpp	2011-11-22 23:36:21 +0000
+++ dolfin/mesh/IntervalCell.cpp	2011-11-24 12:39:12 +0000
@@ -178,7 +178,7 @@
 //-----------------------------------------------------------------------------
 double IntervalCell::facet_area(const Cell& cell, uint facet) const
 {
-  return 0.0;
+  return 1.0;
 }
 //-----------------------------------------------------------------------------
 void IntervalCell::order(Cell& cell,