dolfin team mailing list archive
-
dolfin team
-
Mailing list archive
-
Message #25931
Re: Demos and CMakeLists.txt
-
To:
Joachim Berdal Haga <jobh@xxxxxxxxx>
-
From:
Johan Hake <hake.dev@xxxxxxxxx>
-
Date:
Fri, 14 Sep 2012 16:09:14 +0200
-
Cc:
dolfin-dev <dolfin@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<CAPKc5=_RyeDiOAkF1LxtbWUbAEP3DiBHrgRdU3KFGUgSXEQTaA@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0
Why would that be less to maintain? Aren't we talking about 3 lines?
Johan
On 09/14/2012 04:01 PM, Joachim Berdal Haga wrote:
> Would it be acceptable to check the first line of the existing file
> (if any), and skip it if it doesn't say "automatically generated"?
> Less maintenance...
>
> -j.
>
>
> On 14 September 2012 15:50, Johan Hake <hake.dev@xxxxxxxxx> wrote:
>> I think providing hand made CMakeFiles for specific demos should be
>> allowed.
>>
>> Maybe you can introduce a list with excludes in generate-cmakefiles.
>> Something like
>>
>> excludes = ["qtplot"]
>>
>> and then something like:
>>
>> ...
>> if os.path.basename(root) in excludes:
>> continue
>> ...
>>
>> Johan
>>
>> On 09/14/2012 03:40 PM, Joachim Berdal Haga wrote:
>>> I have a demo that I'd like to put in demo/undocumented. It
>>> demonstrates embedding of the plot window in a qt application.
>>>
>>> It requires a custom CMakeLists.txt, but I'm concerned it will be
>>> overwritten by one that is automatically generated by
>>> cmake/scripts/generate-cmakefiles.
>>>
>>> Will this be a problem?
>>>
>>> -j.
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~dolfin
>>> Post to : dolfin@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~dolfin
>>> More help : https://help.launchpad.net/ListHelp
>>>
>>
Follow ups
References