← Back to team overview

dolfin team mailing list archive

Re: SymmetricAssembler

 

On Tue, Oct 2, 2012 at 1:04 PM, Joachim Berdal Haga <jobh@xxxxxxxxx> wrote:
>>> 1) What exactly is wrong with it? We have been through this before; it
>>> is useful, it is efficient, and it is no more convoluted than the
>>> standard assembler (in fact, the logic is the same for the most part).
>>>
>>
>> Your later point is why the symmetric/system assembler will/should be
>> merged - they are for a large part the same, but double the work when
>> changes are necessary.
>
> Agreed - although SystemAssembler uses a different ordering/logic
> (same as the OpenMP assembler?) than the symmetric and standard
> assemblers, so we will have to decide which is preferred before
> merging.
>

What's the difference in the logic?

Garth

>>> 2) Why not tell me if it's broken, so I can fix it, instead of removing it?
>>
>> It hasn't been removed. It doesn't follow the design pattern of the
>> other assemblers (or DOLFIN objects in general), which means it could
>> not inherit the AssemblerBase member functions. It needs someone to
>> fix it.
>
> Sure. I can fix it. But only if I know about it, and I only found out
> by accident.
>
> -j.


Follow ups

References