← Back to team overview

dolfin team mailing list archive

Re: [noreply@xxxxxxxxxxxxx: [Branch ~dolfin-core/dolfin/trunk] Rev 7055: merge cmake.local revert]

 

On Wed, Oct 31, 2012 at 8:40 AM, Anders Logg <logg@xxxxxxxxx> wrote:
> On Wed, Oct 31, 2012 at 08:37:18AM +0000, Garth N. Wells wrote:
>> On Wed, Oct 31, 2012 at 8:13 AM, Anders Logg <logg@xxxxxxxxx> wrote:
>> > Why did you remove it? Is -DCMAKE_SKIP_RPATH:BOOL=ON not safe to
>> > include?
>> >
>> > It breaks my build if I remove it. Dorsal uses it to build DOLFIN.
>> >
>>
>> The change broke my builds.
>
> ok. So instead of iterating commits turning this option ON/OFF, does
> anyone know why using rpaths breaks the Dorsal build?
>

Yes, I'm happy to test until we come to a solution, but would like to
not make changes until then.

> How is your build different from the Dorsal build?
>

Not using Dorsal, I don't know. I do not add the paths of my
home-baked libraries to LD_LIBRARY_PATH, but rely on CMake to 'bake
in' the library paths (rpath). I like this because I can be sure which
libs are being linked in, rather than random bits and pieces that lie
in the system paths.

What error do you get from Dorsal?

Garth

> --
> Anders
>
>
>> >
>> > ---------- Forwarded message ----------
>> > From: noreply@xxxxxxxxxxxxx
>> > To: Anders Logg <logg@xxxxxxxxx>
>> > Cc:
>> > Date: Wed, 31 Oct 2012 07:46:17 -0000
>> > Subject: [Branch ~dolfin-core/dolfin/trunk] Rev 7055: merge cmake.local revert
>> > Merge authors:
>> >   Garth Wells (garth-wells)
>> > ------------------------------------------------------------
>> > revno: 7055 [merge]
>> > committer: Garth N. Wells <gnw20@xxxxxxxxx>
>> > branch nick: testing
>> > timestamp: Wed 2012-10-31 07:45:07 +0000
>> > message:
>> >   merge cmake.local revert
>> > modified:
>> >   cmake.local
>> >
>> >
>> >
>> > Your team DOLFIN Core Team is subscribed to branch lp:dolfin.
>> > To unsubscribe from this branch go to https://code.launchpad.net/~dolfin-core/dolfin/trunk/+edit-subscription
>> >
>> > === modified file 'cmake.local'
>> > --- cmake.local 2012-10-30 22:27:48 +0000
>> > +++ cmake.local 2012-10-31 07:43:08 +0000
>> > @@ -22,7 +22,6 @@
>> >        -DDOLFIN_ENABLE_TESTING=true \
>> >        -DDOLFIN_ENABLE_BENCHMARKS=true \
>> >        -DCMAKE_BUILD_TYPE=Developer \
>> > -      -DCMAKE_SKIP_RPATH:BOOL=ON \
>> >        $CMAKE_EXTRA_ARGS \
>> >        ..
>> >
>> >
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~dolfin
>> > Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~dolfin
>> > More help   : https://help.launchpad.net/ListHelp
>> >


Follow ups

References