dorsal team mailing list archive

[Johannes Ring <johannr@xxxxxxxxx>]

On Tue, Feb 8, 2011 at 2:33 PM, Johannes Ring <johannr@xxxxxxxxx> wrote:
> On Tue, Feb 8, 2011 at 2:30 PM, Joachim Berdal Haga <jobh@xxxxxxxxx> wrote:
>>> I guess that adding
>>>
>>>  TARGETS=('' install runtests)
>>>
>>> in dolfin.package should do the trick. We would also need to set
>>> -DDOLFIN_ENABLE_TESTING:BOOL=ON in CONFOPTS, unless we turn this on by
>>> default in DOLFIN.
>>
>> I'd suggest not actually compiling/running the tests, just making them
>> available by setting CONFOPTS appropriately (and optionally telling the user
>> how to run the tests in the final printout). Or maybe use the new quick test
>> target?
>
> Or we can add something in dorsal.cfg to turn testing on or off.
> Default could be off.

Is the attached diff an acceptable fix for this?

Johannes

=== modified file 'FEniCS/packages/dolfin.package'
--- FEniCS/packages/dolfin.package	2011-01-17 13:46:52 +0000
+++ FEniCS/packages/dolfin.package	2011-02-08 16:57:04 +0000
@@ -3,3 +3,9 @@
 PACKING=bzr
 BUILDCHAIN=cmake
 CONFOPTS="-DCMAKE_SKIP_RPATH:BOOL=ON -DCGAL_DISABLE_ROUNDING_MATH_CHECK:BOOL=ON"
+
+if [ ${ENABLE_TESTING} = true ]
+then
+    CONFOPTS="-DDOLFIN_ENABLE_TESTING:BOOL=ON ${CONFOTPS}"
+    TARGETS=('' install runtests)
+fi

=== modified file 'dorsal.cfg'
--- dorsal.cfg	2010-09-02 00:38:48 +0000
+++ dorsal.cfg	2011-02-08 16:54:50 +0000
@@ -13,3 +13,5 @@
 PROCS=1
 # Would you like to build stable versions of FEniCS projects?
 STABLE_BUILD=true
+# Would you like to enable testing?
+ENABLE_TESTING=false