← Back to team overview

drizzle-discuss team mailing list archive

Re: schema_dictionary.data_dictionary.test

 

We should enable the columns.

Cheers,
   --Brian

On Jun 16, 2010, at 11:12 AM, Patrick Crews <gleebix@xxxxxxxxx> wrote:

Hi,

I was just going through this test and was curious why we comment out all of the results:
From the plugin/schema_dictionary/tests/t/data_dictionary.test

--replace_column 1 #  6 # 7 # 8 # 9 # 10 #
SELECT count(*) FROM columns;

--replace_column 1 #  6 # 7 # 8 # 9 # 10 #
SELECT count(*) FROM indexes;

<snip>
--replace_column 1 # 2 # 3 #
SELECT TABLE_SCHEMA,TABLE_NAME,COLUMN_NAME from COLUMNS ORDER BY TABLE_SCHEMA,TABLE_NAME;

This ends up producing a .result file / diffs_for_failure that look like:
schema_dictionary.data_dictionary                            [ fail ]
--- /publisher_tests/tests/../plugin/schema_dictionary/tests/r/ data_dictionary.result 2010-06-16 02:59:20.010036000 +0300 +++ /publisher_tests/tests/../plugin/schema_dictionary/tests/r/ data_dictionary.reject 2010-06-16 18:01:03.906621313 +0300
@@ -490,6 +490,11 @@
 #
 #
 #
+#
+#
+#
+#
+#

This doesn't give a lot of useful information beyond the fact that we have more than what we were expecting and we'll have to manually examine what the extra results are. I can get commenting out variable data such as timestamps, but the test as it stands doesn't make a lot of sense to me.

Thanks,
Patrick

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : drizzle-discuss@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp



Follow ups

References