← Back to team overview

dulwich-users team mailing list archive

Re: Other changes?

 

On Wed, 2010-05-19 at 19:02 -0500, Augie Fackler wrote:
> On May 19, 2010, at 6:46 PM, Jelmer Vernooij wrote:
> > On Wed, 2010-05-19 at 18:27 -0500, Augie Fackler wrote:
> >> I noticed you pushed only one of my most recent set of changes - is
> >> there something wrong with the other changesets? If so, can we do  
> >> some
> >> kind of code review on them so I can fix them up, either by  
> >> installing
> >> gerrit somewhere or just doing patchbombs on the dulwich-users list?
> >> Either way, I went ahead and rebased my remaining changes on the one
> >> you cherry picked - they're on github in the usual place.
> > I haven't had time to have a look at the other changesets yet, but  
> > this
> > one was trivial enough to cherrypick.
> >
> > I'll look at the others later this week but will need more time for
> > that, possibly after 0.6.0.
> I'd really like those cleanups (and the deprecation, so it can come  
> out sooner rather than later) in 0.6.0 rather than after if possible  
> since there's a protocol violation fix in there.
I'm happy to land the protocol compliancy bits but the GitClient
refactoring needs more discussion and I don't want to postpone the
release further because of that. 

Cheers,

Jelmer

Attachment: signature.asc
Description: This is a digitally signed message part


Follow ups