dulwich-users team mailing list archive

[Jelmer Vernooij <jelmer@xxxxxxxxx>]

On Mon, 2010-06-28 at 07:43 -0500, Augie Fackler wrote:
> On Jun 28, 2010, at 6:29 AM, Jelmer Vernooij wrote:
> > On Sun, 2010-06-27 at 22:05 -0500, Augie Fackler wrote:
> >> I feel like there was more we wanted done to these patches, but I can't
> >> remember what it was for the life of me (and searching my email with
> >> two different tools has failed to jog my memory.) Happy to patchbomb
> >> these to the list as well, but figured I'd just link to diffs for now
> >> since git-send-email isn't making sense at the moment.
> >> 
> >>> client: refactor GitClient subclasses to enhance code commonality
> >>> 
> >>> This makes GitClient abstract, and the concrete subclasses now share
> >>> all substantive implementation code with their superclass. This makes
> >>> the subclasses behave more uniformly, and makes testing the client
> >>> implementations easier.
> >>> <http://github.com/durin42/dulwich/commit/c43b4d91e959fd523bc98c59d030484e423bf37d>
> >> 
> >> The client refactor as before, but without changing how we do protocol
> >> dispatch (I'll follow up with that later.) Is there something I've
> >> managed to forget in cleaning this one up?
> > I think you've covered everything - the most important thing was the
> > location of can_read. The mail thread in question is here:
> > https://lists.launchpad.net/dulwich-users/msg00078.html
> > 
> >>> compat.test_client: test SubprocessGitClient and SSHGitClient
> >>> <http://github.com/durin42/dulwich/commit/198793d3e4d71b3349b8d40874f4559de9ceca89>
> >> 
> >> Shouldn't be terribly controversial, assuming the first one is ok?
> > Yep, I'm happy to merge that one later today. Thanks!
> Awesome, thanks!
Merged now, thanks for your patience with this patch. 

After the alt-ssh-path patch gets updated and lands I'll see if I can do
another release.

Cheers,

Jelmer

Attachment: signature.asc
Description: This is a digitally signed message part