← Back to team overview

dulwich-users team mailing list archive

Re: make dulwich compile with mingw

 

I'm not a huge fan of inlining this function as opposed to a
conditionally-defined macro or header file. What if we want to use strlen in
other places?

On Tue, Aug 17, 2010 at 14:36, Jelmer Vernooij <jelmer@xxxxxxxxx> wrote:

> On Tue, 2010-08-17 at 23:30 +0200, Hans Kolek wrote:
> > I've patched dulwich to compile with mingw. The patch is attached. As
> > you can see I've just removed the strnlen call and replaced it with
> > its implementation.
> This looks alright, but please don't use declarations after statements,
> as they break some compilers.
>
> Cheers,
>
> Jelmer
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dulwich-users
> Post to     : dulwich-users@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dulwich-users
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References