dulwich-users team mailing list archive

[Jelmer Vernooij <jelmer@xxxxxxxxx>]

On Sun, 2010-12-05 at 07:38 -0600, Augie Fackler wrote:
> On Dec 5, 2010, at 7:37 AM, Jelmer Vernooij wrote:
> 
> > On Sun, 2010-11-28 at 17:46 -0600, Augie Fackler wrote:
> >> Found this while toying around more with hgit adding init
> >> support. Without this patch, all repositories are created with bare =
> >> true in .git/config, even if a non-bare repository was created.
> >> 
> >> I don't care for the use of the singleton for _unset, but I wasn't
> >> quite clear if it'd be OK to change the behavior of that method
> >> entirely - I only see one other call site, also in dulwich.repo, so if
> >> it'd be alright to just require callers to specify bare to _init_files
> >> I think I'd rather just require passing that parameter than trying to
> >> do something clever for the default.
> > Yeah, I'd prefer that as well. I'm not too concerned about backwards
> > compatibility given this is a private method. 
> > 
> > I'll merge and make the appropriate changes.
> I've already made that change locally, would you like a resend?
Yes, that'd be great. 

Cheers,

Jelmer

Attachment: signature.asc
Description: This is a digitally signed message part